1845333 - Create submenu panel-items for open tabs "more" menu

Status: RESOLVED FIXED

(Firefox :: Firefox View, task)

Description

[Sarah Clements [:sclements]]

Breaking this out from bug 1831141, since this is more work to implement since we don't have this option with the current PanelItem and PanelList web components.

This is needed for the two items with the arrow that have the same submenus as tab context menus:

[Open tabs]
Close Tab
Move Tab >
—-------------------
Copy Link
Send Tab to Device >

The spec for the submenu's is here.

Comment 1

[Sarah Clements [:sclements]]

Attachment: Bug 1845333 - Add submenu items to open tabs more menu r=#fxview-reviewers,mstriemer

• Modify panel-list and panel-item to support submenu list items
• Add submenu items for Move Tabs and Send Tabs to Devices to open tabs
• Add test coverage for submenu items in open tabs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36af6059cb2b
Add submenu items to open tabs more menu r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,sfoster,flod

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset 36af6059cb2b (Bug 1845333) for causing failures in browser_opentabs_firefoxview_next.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=O-WR_gzQRGmO2VuhKAqexQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=36af6059cb2bf68c559c9b66bb1b543771794d4e

Log: https://treeherder.mozilla.org/logviewer?job_id=429812053&repo=autoland&lineNumber=16451

Backout: https://hg.mozilla.org/integration/autoland/rev/94eb416f65664a564d942491a8a252a0d05504c7

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/424ebf6979de
Add submenu items to open tabs more menu r=mstriemer,fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,reusable-components-reviewers,sfoster,flod,tgiles

Comment 5

[Iulian Moraru]

Backed out for causing mochitest-chrome failures on test_opentabs.html.

• Push with failures

• Failure log
  There is also this TV job if you want to take a look before re-landing.

• Backout link

[task 2023-09-20T18:35:07.590Z] 18:35:07     INFO - TEST-START | browser/components/firefoxview/tests/chrome/test_opentabs.html
[task 2023-09-20T18:35:07.596Z] 18:35:07     INFO - GECKO(1573) | [Parent 1573, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/chrome/nsChromeRegistry.cpp:182
[task 2023-09-20T18:35:07.596Z] 18:35:07     INFO - GECKO(1573) | [Parent 1573, Main Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/checkouts/gecko/chrome/nsChromeProtocolHandler.cpp:73
[task 2023-09-20T18:35:07.645Z] 18:35:07     INFO - GECKO(1573) | [Parent 1573, Main Thread] WARNING: Failed to retarget HTML data delivery to the parser thread.: file /builds/worker/checkouts/gecko/parser/html/nsHtml5StreamParser.cpp:1235
[task 2023-09-20T18:35:07.710Z] 18:35:07     INFO - GECKO(1573) | [Parent 1573, Main Thread] WARNING: early callback, or time went backwards: '!aAllowIdleDispatch', file /builds/worker/checkouts/gecko/xpcom/threads/IdleTaskRunner.cpp:198
[task 2023-09-20T18:35:07.832Z] 18:35:07     INFO - GECKO(1573) | [Parent 1573, Main Thread] WARNING: early callback, or time went backwards: '!aAllowIdleDispatch', file /builds/worker/checkouts/gecko/xpcom/threads/IdleTaskRunner.cpp:198
[task 2023-09-20T18:35:07.859Z] 18:35:07     INFO - GECKO(1573) | WARNING: content window passed to PrivateBrowsingUtils.isWindowPrivate. Use isContentWindowPrivate instead (but only for frame scripts).
[task 2023-09-20T18:35:07.860Z] 18:35:07     INFO - GECKO(1573) | pbu_isWindowPrivate@resource://gre/modules/PrivateBrowsingUtils.sys.mjs:23:11
[task 2023-09-20T18:35:07.861Z] 18:35:07     INFO - GECKO(1573) | OpenTabsInView@chrome://browser/content/firefoxview/opentabs.mjs:48:54
[task 2023-09-20T18:35:07.862Z] 18:35:07     INFO - GECKO(1573) | @chrome://browser/content/firefoxview/opentabs.mjs:283:16
[task 2023-09-20T18:35:07.866Z] 18:35:07     INFO - TEST-INFO | started process screentopng
[task 2023-09-20T18:35:08.080Z] 18:35:08     INFO - TEST-INFO | screentopng: exit 0
[task 2023-09-20T18:35:08.080Z] 18:35:08     INFO - TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/chrome/test_opentabs.html | uncaught exception - TypeError: can't access property "getSendTabTargets", this.currentWindow.gSync is undefined at connectedCallback@chrome://browser/content/firefoxview/opentabs.mjs:87:5
[task 2023-09-20T18:35:08.081Z] 18:35:08     INFO - @chrome://browser/content/firefoxview/opentabs.mjs:283:16
[task 2023-09-20T18:35:08.081Z] 18:35:08     INFO - 
[task 2023-09-20T18:35:08.081Z] 18:35:08     INFO - simpletestOnerror@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:2044:18
[task 2023-09-20T18:35:08.081Z] 18:35:08     INFO - @chrome://browser/content/firefoxview/opentabs.mjs:283:16
[task 2023-09-20T18:35:08.081Z] 18:35:08     INFO - GECKO(1573) | JavaScript error: chrome://browser/content/firefoxview/opentabs.mjs, line 87: TypeError: can't access property "getSendTabTargets", this.currentWindow.gSync is undefined
[task 2023-09-20T18:35:08.081Z] 18:35:08     INFO - GECKO(1573) | MEMORY STAT | vsize 11260MB | residentFast 426MB | heapAllocated 191MB
[task 2023-09-20T18:35:08.082Z] 18:35:08     INFO - add_setup | Entering 
[task 2023-09-20T18:35:08.083Z] 18:35:08     INFO - GECKO(1573) | [Parent 1573, Main Thread] WARNING: Please do not use mouseenter/leave events in chrome. They are slower than mouseover/out!: '!nsContentUtils::IsChromeDoc(window->GetExtantDoc())', file /builds/worker/checkouts/gecko/dom/events/EventListenerManager.cpp:436
[task 2023-09-20T18:35:08.083Z] 18:35:08     INFO - GECKO(1573) | [Parent 1573, Main Thread] WARNING: Please do not use mouseenter/leave events in chrome. They are slower than mouseover/out!: '!nsContentUtils::IsChromeDoc(window->GetExtantDoc())', file /builds/worker/checkouts/gecko/dom/events/EventListenerManager.cpp:436
[task 2023-09-20T18:35:08.084Z] 18:35:08     INFO - add_setup | Leaving 
[task 2023-09-20T18:35:08.085Z] 18:35:08     INFO - add_task | Entering open_tab_same_window
[task 2023-09-20T18:35:08.135Z] 18:35:08     INFO - GECKO(1573) | [Parent 1573, Main Thread] WARNING: early callback, or time went backwards: '!aAllowIdleDispatch', file /builds/worker/checkouts/gecko/xpcom/threads/IdleTaskRunner.cpp:198
[task 2023-09-20T18:35:08.272Z] 18:35:08     INFO - GECKO(1573) | [Parent 1573, Main Thread] WARNING: early callback, or time went backwards: '!aAllowIdleDispatch', file /builds/worker/checkouts/gecko/xpcom/threads/IdleTaskRunner.cpp:198
[task 2023-09-20T18:35:08.343Z] 18:35:08     INFO - GECKO(1573) | [Parent 1573, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, NS_OK) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/caps/BasePrincipal.cpp:1150
[task 2023-09-20T18:35:08.408Z] 18:35:08     INFO - GECKO(1573) | [Parent 1573, Main Thread] WARNING: early callback, or time went backwards: '!aAllowIdleDispatch', file /builds/worker/checkouts/gecko/xpcom/threads/IdleTaskRunner.cpp:198
[task 2023-09-20T18:35:08.418Z] 18:35:08     INFO - TEST-PASS | browser/components/firefoxview/tests/chrome/test_opentabs.html | There is one window. 

Comment 6

[Sarah Clements [:sclements]]

Dang! I'll take a look at the test_opentabs.html but the TV job looks like an existing intermittent with browser_recentlyclosed_firefoxview_next.js. I could use requestLongerTimeout(N) as a temporary measure.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c49ded10a66b
Add submenu items to open tabs more menu r=mstriemer,fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,reusable-components-reviewers,sfoster,flod,tgiles

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c49ded10a66b