1877886 - NntpIncomingServer._newsrcTimer not cleaned up if the server is removed

Status: RESOLVED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[Geoff Lankow (:darktrojan)]

The constructor of NntpIncomingServer starts a repeating timer to update the newsrc file, but if the server is removed this timer isn't cleaned up. This leaks the object and leads to error messages:

NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIMsgFolder.subFolders]
writeNewsrcFile@resource:///modules/NntpIncomingServer.jsm:450:24
NntpIncomingServer/this._newsrcTimer<@resource:///modules/NntpIncomingServer.jsm:67:53
notify@resource://gre/modules/Timer.sys.mjs:49:17

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1877886 - Stop timer in NntpIncomingServer when it gets shut down. r=#thunderbird-reviewers

Comment 2

[Magnus Melin [:mkmelin]]

Hmm, I wonder if bug 1870821 could be something similar...

Comment 3

[Geoff Lankow (:darktrojan)]

Maybe, although timers this long are explicitly ignored for that check, so it's not this particular timer.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0e2b3b2240d3
Stop timer in NntpIncomingServer when it gets shut down. r=mkmelin