1877937 - File dialog opens behind main window if triggered while "Bookmark this page" popup is active

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect, P3)

Description

[Alice0775 White]

Steps to reproduce:

1. Open any web page
2. Click Star button in Address bar
3. Key press Ctrl+O or Ctrl+S

Actual results:
Add/Edit Bookmark dialog will close as expected.
However, File picker dialog does not display.
Then, When click browser anywhere, the dialog will display.

Rarely, The browser UI will get stuck. You'll have to kill it from Task Manager .

Expected results:
File picker dialog should display.

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ed7eb7f238342d0832d1be824c7d98517e2a388a&tochange=2c589e3ed465c63a3648c35f6ac2005f55a8fe25

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:rkraesig, since you are the author of the regressor, bug 1862712, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Ray Kraesig [:rkraesig]]

Rarely, The browser UI will get stuck. You'll have to kill it from Task Manager .

Well, that's an S2 then.

Comment 4

[Bob Hood [:bhood]]

Ray, since this is an S2, any chance we will see something for uplift to Fx123 before release?

Comment 5

[Ray Kraesig [:rkraesig]]

Something, yes. I've literally just now figured out what's going on with the probably-related now-P2 bug 1878568 — it's the WM_DISABLED flag getting stuck. I know how and why it's happening there, but I don't know why it would be happening here. Nonetheless, I can try to fix that bug in a way that should also reduce the severity of this one.

Alice: is it possible that on the attempts when the UI got stuck, you'd double-tapped Ctrl-S or Ctrl-O, and opened two or more file dialogs?

Comment 6

[Alice0775 White]

(In reply to Ray Kraesig [:rkraesig] from comment #5)

Alice: is it possible that on the attempts when the UI got stuck, you'd double-tapped Ctrl-S or Ctrl-O, and opened two or more file dialogs?

yes

Comment 7

[Ray Kraesig [:rkraesig]]

(In reply to Alice0775 White from comment #6)

(In reply to Ray Kraesig [:rkraesig] from comment #5)

Alice: is it possible that on the attempts when the UI got stuck, you'd double-tapped Ctrl-S or Ctrl-O, and opened two or more file dialogs?

yes

Understood. Reclassifying this bug as S3 for the primary issue. We can revisit that if there are still hangs after the fix for bug 1878568 has landed.

Comment 8

[Ray Kraesig [:rkraesig]]

...oh. That's why.

Bizarrely, this seems to only happen when the "Bookmark this Page" popup is open. It doesn't happen with the permissions dropdowns on the left side of the address bar, nor with extension dropdowns like uBlock Origin's or Firefox Profiler's, nor with the hamburger menu.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1862712

Comment 10

[Donal Meehan [:dmeehan]]

:rkraesig is possibly this a bug in nightly only for now?
The regressor mentions "Enable out-of-process file picker on Nightly", though it's not clear to me what gates this it to nightly only

Comment 11

[Ray Kraesig [:rkraesig]]

It's gated to Nightly because that pref being "0" currently means "in-process file picker only" in Beta and Release.

I suppose technically end-users could enable the out-of-process file-picker in Beta or Release manually by changing that pref, but in practice it's Nightly-only.

Comment 12

[Ray Kraesig [:rkraesig]]

— correction. I have just tried this out in Release v123 and it reproduces just fine, even with that pref set to 0 or -1.

Alice, are you sure about that regression window?

Comment 13

[Alice0775 White]

I rechecked the regression window using mozregression. And yes, It is 100% sure.

Comment 14

[Alice0775 White]

Regression window with widget.windows.utility_process_file_picker = -1:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e8a791b6611aebbe314b430b97b2b70b51e2c239&tochange=3e082a66c7215c2a29aabee626dfaf53d74b3dbe

Regressed by Bug 1858225 - Async Win32 file-picker

It means, after Bug 1858225 is fixed, widget.windows.utility_process_file_picker setting value seems to be no longer meaningful.

Comment 15

[Ray Kraesig [:rkraesig]]

Ah. So no, it's not Nightly only, because making the file-picker properly async (even in-process) has the same effect.

(Somewhat bizarrely, I don't seem to be able to reproduce this bug in mozregression at all.)

Comment 16

[Alice0775 White]

if you cannot reproduce, pls try

1. Open any web page
2. Click on Star button in Address bar. And click on Save button.
3. Again click on Star button in Address bar
4. Key press Ctrl+O or Ctrl+S

Comment 17

[Ray Kraesig [:rkraesig]]

That does help reproduce it in mozregression... which is particularly helpful because now I can't reproduce it on a current Nightly.

Bisection shows that, to my complete surprise, the fix for bug 1879608 has also fixed this. Closing as RESOLVED FIXED, I guess.

Comment 18

[Monica Chiorean]

I was able to reproduce the issue on Win11x64 using FF build 124.0a1(2024-02-01) and steps from Comment #16.
Verified as fixed on Win11x64/Ubuntu 22.04/Mac 12.6 using FF builds 125.0b5 and 126.0a1(2024-03-28).