1878051 - Hover effect is active while having a context menu opened

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Bogdan Maris, Desktop QA]

Found in

• Latest Nightly 124.0a1

Affected versions

• Latest Nightly 124.0a1

Tested platforms

• Affected platforms: Windows 11, Ubuntu 22.04
• Unaffected platforms: MacOS 13 (even though something similar happens there as well, more details bellow).

Preconditions

• Have the Tab Hover feature active with browser.tabs.cardPreview.enabled as true in about:config

Steps to reproduce

1. Open two websites in two different tabs.
2. Right click on the tab there is no focus on.
3. Hover over the same tab where the context menu is opened.

Expected result

• Hover effect is not active while context menu is opened.

Actual result

• Hover preview can still be used while having a context menu opened in the browser thus it is possible to have the hover overlap the context menu (Ubuntu) or the hover can be overlapped by the context menu (Windows).

Regression range

• Not a regression since this is reproducible on old Nightly build from 2024-01-13 where this feature officially landed.

Additional notes

• On Chrome and Firefox (Mac) the hover effect is disabled if having a context menu opened.
• In Firefox (mac included) the hover is also enabled if having hamburger menu opened, not in Chrome though. In Chrome the hover effect is active if Music control or Extensions menus are open but not their "hamburger" menu. We need to have a consistent behavior here I think.
• Probably this is not a specific Tabbed Browser issue but it does negatively affect this feature imho.

Comment 1

[Bogdan Maris, Desktop QA]

Attachment: Screenshot showing the issue

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:bmaris, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 3

[Jeremy Swinarton]

This appears to be an overall issue with context menus in Firefox, I'm not sure I agree with this being classified as a tab preview issue (though the existence of tab preview certainly makes it more obvious).

On MacOS, when a context menu is open, all browser interactivity is disabled -- this includes not only elements of the chrome but the interactive elements in the content area. For example, if you open a context menu on a Bugzilla page and then hover the mouse over the row of links in the top nav (Browse, Advanced Search, etc), nothing happens. Without the context menu, they change colour on hover.

This behaviour is implemented correctly by Edge and Chrome on Windows -- only Firefox is the outlier here. I have not tested on Ubuntu.

Comment 4

[Chris Peterson [:cpeterson]]

This bug is a THP release blocker.

Comment 5

[Jeremy Swinarton]

I still think that the best option is to fix the underlying issue with the context menu itself, so that all interactivity in the browser is disabled while the context menu is open. Since this outside the scope of tab hover preview I have filed bug1897220 to address this. In my opinion the behaviour on Windows and Ubuntu should be identical to MacOS.

That said, we can still address this directly within THP to unblock this, so I am going to work on a local solution that disables the tabstrip on context menu. I will add an additional ticket to remove this code once 1897220 is addressed.

Comment 6

[Jeremy Swinarton]

Attachment: Bug 1878051: Prevent THP from opening if panels or contextmenus open r?dwalker

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0b0d70fe948
Prevent THP from opening if panels or contextmenus open r=dwalker,tabbrowser-reviewers

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e0b0d70fe948

Comment 9

[Bogdan Maris, Desktop QA]

Checking on latest Nightly 128.0a1 from today across platforms (macOS 13, Windows 11 and Ubuntu 22.04) the mouse hover is still active but indeed the tab preview is not displayed anymore while the context menu is active which does fix the issue described here. Even though it's not a final solution since all the other tooltips from different buttons will still work, but that's work that will be done in bug 1897220. Closing this one as verified fixed.