1878111 - New “Clear browsing data and cookies” dialog does not remember the selection

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, defect, P2)

Description

[nicolas m]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:124.0) Gecko/20100101 Firefox/124.0

Steps to reproduce:

In the latest Nightly 124.

Initially:
– Pressed Control + Shift + Delete.
– Pressed Enter.

Later:
– Pressed Control + Shift + Delete.
– Unchecked “Cookies and site data”.
– Pressed Enter.

Even later:
– Pressed Control + Shift + Delete.
– Pressed Enter.

Actual results:

Initially:
– The Clear browsing data and cookies” dialog has different check boxes than before, including “Cookies and site data”.
– I used to have “Cookies” and “Site data” unchecked in the previous design.
– Now “Cookies and site data” was checked as a default and I didn’t see it.
– I didn’t notice and pressed Enter, effectively loosing all my cookies as well as years of site data (oops). This is a destructive action.

Later:
– I reopened the new dialogue.
– Make sure to uncheck “Cookies and site data” so that I don’t do it again.

Even later:
– I reopened the dialogue.
– “Cookies and site data” and checked again.

Expected results:

– The new dialogue should remember what checkboxes were checked the previous time and keep that selection.
– Important for people who quickly do Control + Shift + Delete + Pressed Enter to delete what they are used to delete (i.e. History and Cache, for instance).
– Ideally, the new dialogue when opening for the first time should also be matched with whatever the user had checked in the previous version of the dialogue. Of course it cannot be a 100% match, but in doubt, UNcheck the marks to avoid destructive action.

I would also argue that Cookies (keep you logged and tracked, not bad to delete from time to time) and Site data (sometimes including saved documents and other created work in online apps, very bad to delete without reviewing) should be kept separated.

Comment 1

[nicolas m]

Attachment: Screencast of a checkmarked not being saved when reopening

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Data Sanitization' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Paul Zühlcke [:pbz]]

We would have to remember the user selection per entry point. Harshit, did we already file a bug for this / is this a dupe?

Comment 5

[Harshit Sohaney [:hsohaney]]

Thanks for reporting this bug! We now have default checked options based on where you open the dialog from. We didn't implement remembering previous user options for normal history clearing since we shifted to defaults.
We can consider moving back to remembering user selection since it looks like it may have more use cases for users!

Comment 6

[nicolas m]

Thanks for the replies :)

Just confirming that in my use case, it’s very very annoying.
I have made the mistake about 100 times in the last few days, I keep deleting everything and getting logged out of everywhere xD
Control + Shift + Delete + Enter has been in my daily muscle memory for 15+ years, hard to get rid of it!
And I lost gigabytes of site data, which is probably a good clean-up in some respect, but I can’t imagine how much stuff I wanted to keep there was there.

So I would love if you could re-implement remembering the user selection! :)

Comment 7

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1878111 - (part 1) Remember user clearing options in the new clear history dialog. r?pbz

Comment 8

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1878111 - (part 2) Tests for remembering user prefs in the clear history dialog. r?pbz

Depends on D201274

Comment 9

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1878111 - Migrate prefs for clear history dialog in both clearHistory and clearOnShutdown contexts. r?pbz

Depends on D201275

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/436b082f2e59
(part 1) Remember user clearing options in the new clear history dialog. r=pbz
https://hg.mozilla.org/integration/autoland/rev/81b85259c9fd
(part 2) Tests for remembering user prefs in the clear history dialog. r=pbz

Comment 11

[Cristian Tuns]

Backed out for causing bc failures in browser_clearSiteData.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/siteData/browser_clearSiteData.js | Uncaught exception in test bound - Clear button should be disabled - timed out after 50 tries.

Comment 12

[Harshit Sohaney [:hsohaney]]

Apologies, it looks like the fix I had for that got lost in some rebasing. I've added it again and have pushed it for review! The change should be there soon

Comment 13

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1878111 - (part 3) Split up tests for the new clear history dialog to prevent timeout. r?pbz

Depends on D201275

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bab69886226
(part 1) Remember user clearing options in the new clear history dialog. r=pbz
https://hg.mozilla.org/integration/autoland/rev/4cdf4dc04988
(part 2) Tests for remembering user prefs in the clear history dialog. r=pbz,settings-reviewers,mconley

Comment 15

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/3bab69886226
https://hg.mozilla.org/mozilla-central/rev/4cdf4dc04988

Comment 17

[nicolas m]

Thank you for fixing it!!

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d00a8db8a15
(part 3) Split up tests for the new clear history dialog to prevent timeout. r=pbz
https://hg.mozilla.org/integration/autoland/rev/c29362057d78
Migrate prefs for clear history dialog in both clearHistory and clearOnShutdown contexts. r=pbz,mconley

Comment 19

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9d00a8db8a15
https://hg.mozilla.org/mozilla-central/rev/c29362057d78