1878281 - China repack (CN) new tab extension fails with "Oops, something went wrong loading this content."

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Kestrel]

Attachment: Error displayed when opening new tabs in Firefox China repack

STR:

1. Install the Firefox China repack.
2. Alternatively install the extension [e-mail] in regular Nightly.
3. Create a new tab.

"Oops, something went wrong loading this content."

DOMException: An exception was thrown  instrument.js:109:32
  sendMessage asrouter-utils.js:21
  requestMessage asrouter-content.jsx:192
  componentWillMount asrouter-content.jsx:212

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=12253bf8fb887ca254a0a575fb7dbb1dfd6c404b&tochange=09d99f03f93eb8fb9c691180dd0ee16656ce6481

Regressed by Bug 1715158.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:mconley, since you are the author of the regressor, bug 1715158, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Looking.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1878281 - Stub out NEWTAB_MESSAGE_REQUEST handling for legacy privileged addons. r?mkaply!

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Hi! Do you have a moment to look at a very small kludge fix in ASRouterChild? Apparently, there are still some privileged addons out there that send the NEWTAB_MESSAGE_REQUEST message. :/

Comment 5

[Punam Dahiya [:pdahiya]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #4)

Hi! Do you have a moment to look at a very small kludge fix in ASRouterChild? Apparently, there are still some privileged addons out there that send the NEWTAB_MESSAGE_REQUEST message. :/

Thanks @mconley for fix, just accepted. @mkaply do you know what CN repack used this call for. Couldn't find it in https://github.com/mozilla-extensions/china-newtab?

Comment 6

[Mike Kaply [:mkaply]]

There's a script that is loaded remotely that uses it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/312701582d83
Stub out NEWTAB_MESSAGE_REQUEST handling for legacy privileged addons. r=mkaply,omc-reviewers,pdahiya

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/312701582d83

Comment 9

[Mike Kaply [:mkaply]]

Attachment: Bug 1878281 - Stub out NEWTAB_MESSAGE_REQUEST handling for legacy privileged addons. r?mkaply!

Original Revision: https://phabricator.services.mozilla.com/D201094

Comment 10

[Phabricator Automation]

Uplift Approval Request

• User impact if declined: New Tab extension doesn't work
• Is Android affected?: no
• Steps to reproduce for manual QE testing: In bug
• String changes made/needed: None
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Explanation of risk level: Automated test and just makes an old message do nothing
• Risk associated with taking this patch: Very low
• Needs manual QE test: no

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9379488 [details]
Bug 1878281 - Stub out NEWTAB_MESSAGE_REQUEST handling for legacy privileged addons. r?mkaply!

We are in RC week now, uplift requests should target mozilla-release. Rejecting the uplift request as the patch needs to be rebased to apply to the branch.
We could target the planned desktop dot release mid cycle to uplift an updated patch. Thanks

Comment 12

[Mike Kaply [:mkaply]]

Attachment: Bug 1878281 - Stub out NEWTAB_MESSAGE_REQUEST handling for legacy privileged addons. r=mconley

Original Revision: https://phabricator.services.mozilla.com/D201094

Comment 13

[Mike Kaply [:mkaply]]

Attachment: Bug 1878281 - Stub out NEWTAB_MESSAGE_REQUEST handling for legacy privileged addons.

Original Revision: https://phabricator.services.mozilla.com/D202313

Comment 14

[Phabricator Automation]

Uplift Approval Request

• Risk associated with taking this patch: Very low.
• Explanation of risk level: Doesn't change behavior, just stubs out an old message. Has test.
• User impact if declined: China build broken
• String changes made/needed: None
• Needs manual QE test: no
• Code covered by automated testing: yes
• Is Android affected?: no
• Fix verified in Nightly: yes
• Steps to reproduce for manual QE testing: In bug

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/213c5efd8131

Comment 16

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello!
Reproduced the issue on Windows 10x64 with Firefox 123.0 (20240213221259) this link (from my understanding the [e-mail] is included in this repack. I have also verified it's presence inside the profile > extension folder). Opening a new tab will show the error mentioned in comment 0 and the error in the web console.

The issue is verified fixed on Windows 10x64 with Firefox 123.0.1 (20240304104836) zh-CN and en-US builds from this link and Firefox 124.0b7 (20240304091753) zh-CN and en-US builds from this link. When opening a new tab, the errors referenced in comment 0 will no longer be displayed, and the new tab will appear as it did in Firefox 121 (before bug 1715158).