[tracking] mozillaonline addons/firefox CN distribution

NEW
Unassigned

Status

()

Toolkit
WebExtensions: Untriaged
8 months ago
14 hours ago

People

(Reporter: mixedpuppy, Unassigned)

Tracking

(Depends on: 16 bugs, Blocks: 1 bug)

49 Branch
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: triaged)

(Reporter)

Description

8 months ago
MozillaOnline (CN distribution) includes a number of addons by default.

cpmanager@mozillaonline.com
cehomepage@mozillaonline.com
tabtweak@mozillaonline.com
easyscreenshot@mozillaonline.com
commonfix@mozillaonline.com
coba@mozilla.com.cn
wx-assistant@mozillaonline.com
quicklaunch@mozillaonline.com
share_all_cn@mozillaonline.com
(Reporter)

Comment 1

8 months ago
Issues encountered during conversion of easyscreenshot [I'll have to see if solutions or bugs exist for any of these]

1. We lose the ability to style the navbar button to make it consistent
   with browser; Bug 1207597 ?
2. We can't use the same button id for it to stay where it was (navbar, 
   menu panel, customization palette);
3. We lose the ability to communicate with other extensions, e.g.
   cpmanager, our main extension;
4. We now have to use the scroll and capture approach for the full page
   screenshot, which takes longer than the "old" drawWindow call and
   involves handling fixed positioned element in the page; Bug 1310318
5. I have not been able to figure out how to copy the edited screenshot 
   into the clipboard in an extension page, the selection/execCommand combo
   doesn't seem to work for any thing but text;
6. It's not possible to let user customize the WebExtensions defined
   shortcuts;
7. No visual clue when a badged navbar button (all WebExtensions ones)
   is disabled. Bug 1204609
Depends on: 1204609, 1310318, 1207597
(Reporter)

Updated

8 months ago
Depends on: 1311500
(In reply to Shane Caraveo (:mixedpuppy) from comment #1)
> 
> 1. We lose the ability to style the navbar button to make it consistent
>    with browser; Bug 1207597 ?

Yes, we were trying to match all the variants of Fx toolbar styles[1]: inverted, hi-dpi, different versions of macOS or Windows. Bug 1207597 sounds like helpful.

> 3. We lose the ability to communicate with other extensions, e.g.
>    cpmanager, our main extension;

We have an unified on/off switch inside cpmanager to control tracking pings we send from other extensions. This used to be a `try { Cu.import(...) ... } catch(ex) { ... }`, maybe bug 1258360 would be helpful here.

> 6. It's not possible to let user customize the WebExtensions defined
>    shortcuts;

See [2], "If a key combination is already used by the browser (for example, "Ctrl+Shift+R"), or by an existing add-on, then you can't override it. You will be allowed to define it, but your event handler will not be called when the user enters it." We used to make the shortcuts customizable for this, but it's no longer possible with the `commands` JavaScript API[3].

[1]: https://dxr.mozilla.org/mozilla-central/search?q=path%3Abrowser%2Fthemes+path%3AToolbar+-path%3Aplaces+ext%3Apng
[2]: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/commands#Key_combinations
[3]: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/commands

Updated

8 months ago
Whiteboard: triaged
Recently, we at Beijing office did a preliminary classification of current features of our extensions.

I'll file bugs for the potential API gaps we identified blocking this one.

For each of the features, we might need a new API created (or better, one already planned or exists but I'm not aware of it) or maybe it's better to upstream the work into the vanilla Firefox.

Updated

6 months ago
Depends on: 1329853

Updated

6 months ago
Depends on: 1322304

Updated

6 months ago
Depends on: 1329860

Updated

6 months ago
Depends on: 1329868

Updated

6 months ago
Depends on: 1329874
(In reply to Shane Caraveo (:mixedpuppy) from comment #1)
> 5. I have not been able to figure out how to copy the edited screenshot 
>    into the clipboard in an extension page, the selection/execCommand combo
>    doesn't seem to work for any thing but text;

Bug 1325759
Depends on: 1325759
(Reporter)

Updated

6 months ago
Blocks: 1303905
TCPSocket will be necessary for our Email notifier extension which has a very minimal implementation of IMAP.
Depends on: 1247628
(In reply to Shane Caraveo (:mixedpuppy) from comment #0)
> share_all_cn@mozillaonline.com

Possible API for this one.
Depends on: 1312098
(In reply to Shane Caraveo (:mixedpuppy) from comment #0)
> tabtweak@mozillaonline.com

Double click a tab to close it.
Open bookmarks/search results in new tab when the current tab is not blank
Depends on: 1246706, 1270763
(In reply to Shane Caraveo (:mixedpuppy) from comment #0)
> cehomepage@mozillaonline.com

Alternative new tab page, and its access to thumbnailing service
Load a webpage into a browser inside about:cehome (may not be necessary per bug 1322304 comment 6) and use it as homepage
Updates to partner bookmarks, based on the predefined keywords in distribution.ini
A few APIs we're interested in but not specific to one extension.
Depends on: 1253419, 1268020, 1315558

Updated

5 months ago
Depends on: 1331557
Depends on: 1333403
No longer depends on: 1333403

Updated

14 hours ago
Depends on: 1331559

Updated

14 hours ago
Depends on: 1356543
You need to log in before you can comment on or make changes to this bug.