187837 - Unify showing and editing of quips

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Gervase Markham [:gerv]]

The patch for bug 159627 was slightly less than ideal; we should unify the
operations of showing and editing quips.

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This patch changes the indentation a bit, so seems bigger than it is. It
unifies the "show" and "edit" operations in the CGI, and makes the template
work right within that. It also changes the order of things in the list to the
standard order for Bugzilla administration, with operations on the right.

Gerv

Comment 2

[Gervase Markham [:gerv]]

Comment on attachment 110740 [details] [diff] [review]
Patch v.1

timeless: could you take a look at this, as you reviewed the original?

Thanks,

Gerv

Comment 3

[timeless]

Comment on attachment 110740 [details] [diff] [review]
Patch v.1

this is more expensive for the show case when the user isn't an admin than
before, but if you don't care then i don't care.

Comment 4

[Gervase Markham [:gerv]]

True, but no, I don't care. This is not a common operation, and so code and UI
simplicity wins over a small perf gain.

Gerv

Comment 5

[Dave Miller [:justdave]]

-> patch author

Comment 6

[Gervase Markham [:gerv]]

Fixed.

Checking in template/en/default/list/quips.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/quips.html.tmpl,v 
<--  quips.html.tmpl
new revision: 1.8; previous revision: 1.7
done
Checking in quips.cgi;
/cvsroot/mozilla/webtools/bugzilla/quips.cgi,v  <--  quips.cgi
new revision: 1.17; previous revision: 1.16
done

Gerv