1878401 - Always pass BrowsingContext to nsIFilePicker::Init

Status: RESOLVED FIXED

(Core :: Widget, task)

Comment 1

[Gregory Pappas [:gregp]]

Attachment: WIP: Bug 1878401 - Always pass BrowsingContext to nsIFilePicker::Init

Comment 2

[Gregory Pappas [:gregp]]

Attachment: Bug 1878401 - part 1 - Pass BrowsingContext to nsIFilePicker::Init instead of mozIDOMWindow

This will improve the situation in bug 1878336

Comment 3

[Gregory Pappas [:gregp]]

Attachment: Bug 1878401 - part 2 - Update nsIFilePicker users in browser/ to pass BrowsingContext to init

Depends on D200546

Comment 4

[Gregory Pappas [:gregp]]

Attachment: Bug 1878401 - part 3 - Update nsIFilePicker users in toolkit/ to pass BrowsingContext to init

Depends on D200547

Comment 5

[Gregory Pappas [:gregp]]

Attachment: Bug 1878401 - part 4 - Update nsIFilePicker users in devtools/ to pass BrowsingContext to init

Depends on D200548

Comment 6

[Gregory Pappas [:gregp]]

Attachment: Bug 1878401 - part 5 - Update nsIFilePicker users in security/ to pass BrowsingContext to init

Depends on D200549

Comment 7

[Gregory Pappas [:gregp]]

Attachment: Bug 1878401 - part 6 - Update nsIFilePicker users in layout/ to pass BrowsingContext to init

Depends on D200550

Comment 8

[Gregory Pappas [:gregp]]

Attachment: Bug 1878401 - part 7 - Pass BrowsingContext to nsIFilePicker::Init in tests

Depends on D200551

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f263b196df96
part 1 - Pass BrowsingContext to nsIFilePicker::Init instead of mozIDOMWindow r=geckoview-reviewers,win-reviewers,emilio,nika,m_kato,rkraesig
https://hg.mozilla.org/integration/autoland/rev/6bcb670ce475
part 2 - Update nsIFilePicker users in browser/ to pass BrowsingContext to init r=extension-reviewers,settings-reviewers,credential-management-reviewers,Gijs,sgalich,migration-reviewers,mconley,robwu
https://hg.mozilla.org/integration/autoland/rev/c83ba4026822
part 3 - Update nsIFilePicker users in toolkit/ to pass BrowsingContext to init r=extension-reviewers,Gijs,ng,robwu
https://hg.mozilla.org/integration/autoland/rev/3c3d67f1fcb7
part 4 - Update nsIFilePicker users in devtools/ to pass BrowsingContext to init r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
https://hg.mozilla.org/integration/autoland/rev/9a4b830334b9
part 5 - Update nsIFilePicker users in security/ to pass BrowsingContext to init r=keeler
https://hg.mozilla.org/integration/autoland/rev/30b5bb590d3e
part 6 -  Update nsIFilePicker users in layout/ to pass BrowsingContext to init r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/6d6952f9df2c
part 7 - Pass BrowsingContext to nsIFilePicker::Init in tests r=extension-reviewers,settings-reviewers,credential-management-reviewers,anti-tracking-reviewers,devtools-reviewers,sgalich,pbz,nchevobbe,zombie,migration-reviewers,mconley

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40fc70d66607
Backed out 8 changesets (bug 1878401, bug 1879041) for causing build bustages  on widget/nsBaseFilePicker.cpp CLOSED TREE

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0034f419b2c
part 1 - Pass BrowsingContext to nsIFilePicker::Init instead of mozIDOMWindow r=geckoview-reviewers,win-reviewers,emilio,nika,m_kato,rkraesig
https://hg.mozilla.org/integration/autoland/rev/b8c8a4b055bb
part 2 - Update nsIFilePicker users in browser/ to pass BrowsingContext to init r=extension-reviewers,settings-reviewers,credential-management-reviewers,Gijs,sgalich,migration-reviewers,mconley,robwu
https://hg.mozilla.org/integration/autoland/rev/cf7bb73f0006
part 3 - Update nsIFilePicker users in toolkit/ to pass BrowsingContext to init r=extension-reviewers,Gijs,ng,robwu
https://hg.mozilla.org/integration/autoland/rev/dafb072aa9c3
part 4 - Update nsIFilePicker users in devtools/ to pass BrowsingContext to init r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
https://hg.mozilla.org/integration/autoland/rev/5bb071fb0514
part 5 - Update nsIFilePicker users in security/ to pass BrowsingContext to init r=keeler
https://hg.mozilla.org/integration/autoland/rev/b7c5a7feb3ae
part 6 -  Update nsIFilePicker users in layout/ to pass BrowsingContext to init r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/e2e731d2d484
part 7 - Pass BrowsingContext to nsIFilePicker::Init in tests r=extension-reviewers,settings-reviewers,credential-management-reviewers,anti-tracking-reviewers,devtools-reviewers,sgalich,pbz,nchevobbe,zombie,migration-reviewers,mconley

Comment 12

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f0034f419b2c
https://hg.mozilla.org/mozilla-central/rev/b8c8a4b055bb
https://hg.mozilla.org/mozilla-central/rev/cf7bb73f0006
https://hg.mozilla.org/mozilla-central/rev/dafb072aa9c3
https://hg.mozilla.org/mozilla-central/rev/5bb071fb0514
https://hg.mozilla.org/mozilla-central/rev/b7c5a7feb3ae
https://hg.mozilla.org/mozilla-central/rev/e2e731d2d484