1879041 - Fix the TypeScript types in the devtools/client/performance panel after Bug 1878401 lands, and other type cleanups

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), task)

Description

[Julien Wajsberg [:julienw]]

Bug 1878401 added a @ts-ignore statement. I looked into it before that bug landed, and saw more things worth cleaning up, so here is a standalone bug to do this.

Comment 1

[Gregory Pappas [:gregp]]

Thanks for looking at this!

Comment 2

[Julien Wajsberg [:julienw]]

Attachment: Bug 1879041 - Fix and clean up the TypeScript types in the devtools performance panel r=canaltinova

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e2b8df3bdd6
Fix and clean up the TypeScript types in the devtools performance panel r=canaltinova,profiler-reviewers

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages on widget/nsBaseFilePicker.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/40fc70d66607fdf294d1bbe4e8a0edeace3e914f

Push with failures

Failure log -> ERROR - /builds/worker/checkouts/gecko/widget/nsBaseFilePicker.cpp:168:36: error: member access into incomplete type 'CanonicalBrowsingContext'

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b2409740c11
Fix and clean up the TypeScript types in the devtools performance panel r=canaltinova,profiler-reviewers

Comment 7

[Gregory Pappas [:gregp]]

Attachment: Bug 1879041 - Fix devtools failure

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3338c36501e4
Fix devtools failure. CLOSED TREE

Comment 9

[Gregory Pappas [:gregp]]

Attachment: Bug 1879041 - Fix devtools bustage again

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c23419e2b88
Fix devtools bustage again. CLOSED TREE

Comment 11

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4b2409740c11
https://hg.mozilla.org/mozilla-central/rev/3338c36501e4
https://hg.mozilla.org/mozilla-central/rev/9c23419e2b88