1878519 - Prefer recent searches over trending

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P1)

Description

[Dale Harvey (:daleharvey)]

STR:

browser.urlbar.trending.featureGate = true
browser.urlbar.trending.requireSearchMode = false
browser.urlbar.trending.showPrefs = true
browser.urlbar.recentsearches.featureGate = true

And the engine needs to recognise you are in an area they provide trneding suggestions for, North America is usually a good bet.

When the browser opens with a fresh profile we should see the top sites first followed by the rest of the area filled in with trending suggestions. As you do a search the next time the urlbar opens you should see the top sites, then the recent search, then the trending suggestions. As you do more searches they should knock off the trending suggestions until there is only top sites and recent searches

Comment 1

[Dale Harvey (:daleharvey)]

Hey Marco

I was wondering if you had a good pointer here, we get pretty close behaviour if we give RECENT_SEARCH group a bigger flex than the REMOTE_SUGGESTIONS (@ https://searchfox.org/mozilla-central/source/browser/components/urlbar/UrlbarPrefs.sys.mjs#608), however it doesnt behave exactly as above, there usually ends up being at least one trending shown regardless of how many recent searches there are.

Adding some behaviour on top of the existing flex grouping is quite tricky so wondering with your experience around here if you can think the cleanest way to implement this.

Cheers

Comment 2

[Marco Bonardo [:mak]]

(In reply to Dale Harvey (:daleharvey) from comment #1)

Adding some behaviour on top of the existing flex grouping is quite tricky so wondering with your experience around here if you can think the cleanest way to implement this.

I must point out Drew implemented most of the flexibility here, and may have better ideas than me.
I wonder if you could create another sub-group for RECENT_SEARCH and REMOTE_SUGGESTION, where RECENT_SEARCH has flex: Infinity, though I don't remember if a group itself can have a flex value, as you'd want FORM_HISTORY{flex:2} and YOUR_NEW_GROUP{flex: 4}

In practice you'd end up with:
FORM_HISTORY { flex 2 }
GROUP {
flex: 4,
RECENT_SEARCH { flex Infinity }
REMOTE_SUGGESTION { flex 1 }
}

it's likely this requires code changes to work...

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: Bug 1878519 - Prefer recent searches over trending. r=mak

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19ca51da640d
Prefer recent searches over trending. r=mak

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/19ca51da640d

Comment 6

[Dale Harvey (:daleharvey)]

Comment on attachment 9380664 [details]
Bug 1878519 - Prefer recent searches over trending. r=mak

Beta/Release Uplift Approval Request

• User impact if declined: Unable to run experiment for release
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: QA has test plan awaiting landing on beta
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One line minor change
• String changes made/needed:
• Is Android affected?: Yes

Comment 7

[Dianna Smith [:diannaS]]

Comment on attachment 9380664 [details]
Bug 1878519 - Prefer recent searches over trending. r=mak

Approved for 124.0b3

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2372404e021e