1929515 - Screenreader fails to narrate secondary actions buttons when in 'Actions' mode

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Notes

• VoiceOver seems to be working if typing the first letters of a secondary action and then navigating to the corresponding button via tab.

Found in

• Nightly 134.0a1;

Affected versions

• Nightly 134.0a1;

Affected platforms

• Ubuntu 22;
• macOS 14;
• Windows 10;

Preconditions

• Have browser.urlbar.scotchBonnet.enableOverride set to true
• Have browser.urlbar.searchRestrictKeywords.featureGate set to true
• Have a functional Screenreader tool installed

Steps to reproduce

1. Enable Screenreader.
2. Launch Firefox and open the Dedicated Search Button.
3. Select ‘Actions’ from the dropdown.
4. Navigate with TAB key through the list of secondary action buttons.

Expected result

• Screenreader narrates secondary actions buttons without any issues.

Actual result

• Screenreader fails to narrate secondary actions buttons.

Regression range

• Not a regression.

Comment 1

[Dale Harvey (:daleharvey)]

So this may end up being a dupe of https://bugzilla.mozilla.org/show_bug.cgi?id=1929597, they are definitely related.

The issue is that most of the time when navigating actions the focus is still on the urlbar input field and not on the individual buttons, in this case tab works for navigating the actions buttons but the buttons are not narrated.

Sometimes (and I cant figure how to make it happen reproducably), the cursor seems to go into toolbar navigation mode, I cant navigate between actions with tab as tab will go back to the toolbar (leaving the urlbar open?) but I can navigate the actions with arrows and when in this state the buttons are narrated as expected.

Comment 2

[Dale Harvey (:daleharvey)]

Daisuke I am wondering if the switch between the toolbar handling the focus and the urlbar is something that is related to the code handling how the unified search button gets focus? Especially as I can see when we shift+tab in actions mode (or any search mode) we get. a highlighted search mode icon which we probably dont want.

Comment 3

[Daisuke Akatsuka (:daisuke)]

(In reply to Dale Harvey (:daleharvey) from comment #2)

Daisuke I am wondering if the switch between the toolbar handling the focus and the urlbar is something that is related to the code handling how the unified search button gets focus? Especially as I can see when we shift+tab in actions mode (or any search mode) we get. a highlighted search mode icon which we probably dont want.

Ya, we consume tab key for actions as well.
https://searchfox.org/mozilla-central/rev/cdfe21b20eacfaa6712dd9821d6383859ce386c6/browser/components/urlbar/UrlbarController.sys.mjs#361-374
But, for other search modes as well, the navigation by tab is same as actions. So, in my opinion, as it maintains consistency, want to keep as it is, but what do you think?

Anyway, I confirmed the original issue that can not narrate any actions using tab key. (For my env, arrow key also does not work.)
I will take a look at this issue. Thanks!

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1929515: Assign id to action button when selecting for accessibility

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82eb5e0de103
Assign id to action button when selecting for accessibility r=daleharvey

Comment 6

[amarc]

https://hg.mozilla.org/mozilla-central/rev/82eb5e0de103

Comment 7

[Adrian Florinescu [:aflorinescu]]

Verified as fixed on 136.0a1(22.01.2025) as part of [Nightly 136] Scotch Bonnet testing