1878554 - Simplify the ESLint configuration for aboutwelcome/asrouter/newtab

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Mark Banner (:standard8)]

The newtab ESLint configuration (and asrouter/aboutwelcome configs) have a lot of ESLint rules/configuration that can be simplified, is now redundant, or is using rules that are deprecated.

I want to start tidying this all up, so that it is clearer to see the differences with respect to the rest of mozilla-central.

This depends on bug 1878553 as that's cleaning up some configuration for the .jsx/.config.js files that reside in these directories.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1878554 - Remove now unnecessary jsx features setting for ESLint for aboutwelcome/asrouter/newtab. r?aminomancer!

The parser option was added globally for jsx files in bug 1878009.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1878554 - Simplify react/jsx-no-bind definition for aboutwelcome/asrouter/newtab code. r?aminomancer!

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1878554 - Remove ESLint rule for-direction reference from aboutwelcome/asrouter/newtab configs. r?aminomancer!

It is already enabled as a recommended rule.

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1878554 - Remove ESLint rule require-await for aboutwelcome/asrouter/newtab code. r?aminomancer!

We decided not to use the rule in bug 1381030.

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1878554 - Remove deprecated ESLint rules from aboutwelcome/asrouter/newtab configs. r?aminomancer!

These rules are node specific and not really useful in mozilla central:
handle-callback-err, no-buffer-constructor, no-path-concat, no-process-exit
These rules are not useful as require is only used in configurations:
no-new-require, no-mixed-requires
Prettier already enforces max-statements-per-line
lines-between-class-members isn't handled separately, but if we want to do that we should decide on it globally.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab1e077d3f84
Remove now unnecessary jsx features setting for ESLint for aboutwelcome/asrouter/newtab. r=aminomancer,omc-reviewers
https://hg.mozilla.org/integration/autoland/rev/4eb59e4ebafa
Simplify react/jsx-no-bind definition for aboutwelcome/asrouter/newtab code. r=aminomancer,omc-reviewers
https://hg.mozilla.org/integration/autoland/rev/e0ab31d2de1b
Remove ESLint rule for-direction reference from aboutwelcome/asrouter/newtab configs. r=aminomancer,omc-reviewers
https://hg.mozilla.org/integration/autoland/rev/78839d5841b4
Remove ESLint rule require-await for aboutwelcome/asrouter/newtab code. r=aminomancer,omc-reviewers
https://hg.mozilla.org/integration/autoland/rev/2fc5e630568e
Remove deprecated ESLint rules from aboutwelcome/asrouter/newtab configs. r=aminomancer,omc-reviewers

Comment 7

[Cristian Tuns]

Backed out for causing node failures in aboutwelcome

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | karma /builds/worker/checkouts/gecko/browser/components/aboutwelcome | Coverage for statements (48.15%) in file /builds/worker/checkouts/gecko/browser/components/aboutwelcome/modules/AboutWelcomeDefaults.sys.mjs does not meet per file threshold (80%)

Comment 8

[Mark Banner (:standard8)]

Handling in bug 1878556

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8272abef76b2
Remove now unnecessary jsx features setting for ESLint for aboutwelcome/asrouter/newtab. r=aminomancer,omc-reviewers
https://hg.mozilla.org/integration/autoland/rev/0c0f447b3a7b
Simplify react/jsx-no-bind definition for aboutwelcome/asrouter/newtab code. r=aminomancer,omc-reviewers
https://hg.mozilla.org/integration/autoland/rev/817e069874f1
Remove ESLint rule for-direction reference from aboutwelcome/asrouter/newtab configs. r=aminomancer,omc-reviewers
https://hg.mozilla.org/integration/autoland/rev/c665c72c14a2
Remove ESLint rule require-await for aboutwelcome/asrouter/newtab code. r=aminomancer,omc-reviewers
https://hg.mozilla.org/integration/autoland/rev/674695b55e88
Remove deprecated ESLint rules from aboutwelcome/asrouter/newtab configs. r=aminomancer,omc-reviewers

Comment 10

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/8272abef76b2
https://hg.mozilla.org/mozilla-central/rev/0c0f447b3a7b
https://hg.mozilla.org/mozilla-central/rev/817e069874f1
https://hg.mozilla.org/mozilla-central/rev/c665c72c14a2
https://hg.mozilla.org/mozilla-central/rev/674695b55e88