Move addUtmParams.js to aboutwelcome and rename aboutwelcome content js files to mjs
Categories
(Firefox :: Messaging System, task, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox124 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 2 open bugs)
Details
Attachments
(3 files)
As part of the gradual renaming of files to use the .mjs
extension, I think we can do the content ones in browser/components/aboutwelcome
.
The test ones appear to be difficult to do because of Karma, though we can consider that separately later.
I'm also moving addUtmParams.js
across to aboutwelcome
as it doesn't appear to be used in asrouter
currently.
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 1•1 year ago
|
||
Assignee | ||
Comment 2•1 year ago
|
||
Assignee | ||
Comment 3•1 year ago
|
||
Updated•1 year ago
|
Updated•1 year ago
|
Comment 5•1 year ago
|
||
Backed out for causing node failures in aboutwelcome
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | karma /builds/worker/checkouts/gecko/browser/components/aboutwelcome | Coverage for statements (48.15%) in file /builds/worker/checkouts/gecko/browser/components/aboutwelcome/modules/AboutWelcomeDefaults.sys.mjs does not meet per file threshold (80%)
Assignee | ||
Comment 6•1 year ago
|
||
The issue here is that in moving from .js
to .mjs
I also changed the post processing for Karma to include .mjs
files.
It looks like when aboutwelcome
was setup, the .jsm
files were ignored, so I'll change that to ignoring the .sys.mjs
files (as there are no .jsm
). I'll file a follow-up as we're also going to need to consider/fix the other directories as well.
https://hg.mozilla.org/mozilla-central/rev/b467d32af4c1
https://hg.mozilla.org/mozilla-central/rev/2a2beee03211
https://hg.mozilla.org/mozilla-central/rev/718c9d7cddc5
Description
•