1878556 - Move addUtmParams.js to aboutwelcome and rename aboutwelcome content js files to mjs

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Mark Banner (:standard8)]

As part of the gradual renaming of files to use the .mjs extension, I think we can do the content ones in browser/components/aboutwelcome.

The test ones appear to be difficult to do because of Karma, though we can consider that separately later.

I'm also moving addUtmParams.js across to aboutwelcome as it doesn't appear to be used in asrouter currently.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1878556 - Rename content-src files for aboutwelcome to use .mjs where appropriate. r?aminomancer!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1878556 - Move addUtmParams.js to aboutwelcome and rename to .mjs. r?aminomancer!

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1878556 - Remove unused asrouter/content-src/template-utils.js. r?aminomancer!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb2e02682c8c
Rename content-src files for aboutwelcome to use .mjs where appropriate. r=aminomancer,omc-reviewers
https://hg.mozilla.org/integration/autoland/rev/2ab3a28f5c04
Move addUtmParams.js to aboutwelcome and rename to .mjs. r=aminomancer,omc-reviewers
https://hg.mozilla.org/integration/autoland/rev/425f70fa7e5a
Remove unused asrouter/content-src/template-utils.js. r=aminomancer,omc-reviewers

Comment 5

[Cristian Tuns]

Backed out for causing node failures in aboutwelcome

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | karma /builds/worker/checkouts/gecko/browser/components/aboutwelcome | Coverage for statements (48.15%) in file /builds/worker/checkouts/gecko/browser/components/aboutwelcome/modules/AboutWelcomeDefaults.sys.mjs does not meet per file threshold (80%)

Comment 6

[Mark Banner (:standard8)]

The issue here is that in moving from .js to .mjs I also changed the post processing for Karma to include .mjs files.

It looks like when aboutwelcome was setup, the .jsm files were ignored, so I'll change that to ignoring the .sys.mjs files (as there are no .jsm). I'll file a follow-up as we're also going to need to consider/fix the other directories as well.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b467d32af4c1
Rename content-src files for aboutwelcome to use .mjs where appropriate. r=aminomancer,omc-reviewers
https://hg.mozilla.org/integration/autoland/rev/2a2beee03211
Move addUtmParams.js to aboutwelcome and rename to .mjs. r=aminomancer,omc-reviewers
https://hg.mozilla.org/integration/autoland/rev/718c9d7cddc5
Remove unused asrouter/content-src/template-utils.js. r=aminomancer,omc-reviewers

Comment 8

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/b467d32af4c1
https://hg.mozilla.org/mozilla-central/rev/2a2beee03211
https://hg.mozilla.org/mozilla-central/rev/718c9d7cddc5