1878566 - Settings - Missing checkbox to enable/disable underline links

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Anje]

Windows 10 OS
Thunderbird beta 123.0b2

• Settings > General
• scroll to 'Language & Appearance' section
• click on 'Colours' button

Actual Results
The checkbox to enable/disable 'underline links' is missing.
It was also missing in previous version.

Expected Result
The checkbox to enable/disable 'underline links' option is visible below the 'Link Colours' on right side of window.

Comment 1

[Anje]

Attachment: 123.0b2 - missing-underline.jpg

Image showing expected position of missing option checkbox 'Underline Links'.
Same result in Troubleshoot Mode.

Comment 2

[Hartmut Welpmann [:welpy-cw]]

See bug 1853519.

Comment 3

[Anje]

(In reply to Hartmut Welpmann [:welpy-cw] from comment #2)

See bug 1853519.

Thanks that's useful info as it explains what went wrong but does not explain why it was not corrected.

If I understand correctly - It looks like a preference (browser.underline_anchors) was removed for some reason and therefore the checkbox option seemed redundant hence removed. Sounds logical but it is not and the following explains why.

A new preference 'layout.css.always_underline_links' which set to 'false' by default controls the underline option for links.

Now 'I'm ok with spending a load of time trying to find out what has gone wrong and searching for a preference to turn it all on again, and I'm perfectly ok with using the 'Config Editor'
BUT ... and I stress this next point .... the average user wants to control this sort of thing via 'Settings' and not via 'Config Editor' which many regard as a no-go zone or way too complicated. Please do not make controlling preferences more difficult.

So, this bug is very much a problem for users - I'm asking for the checkbox to be reinserted and this time the code should point to setting the new preference 'layout.css.always_underline_links' to 'false' or 'true' as desired.

Comment 4

[Hartmut Welpmann [:welpy-cw]]

Yes, you are right, there is also bug 1664278, which should be ported to Thunderbird as well.

Comment 5

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1878566 - Port bug 1664278: Expose an "always underline links" checkbox in settings. r=Paenglab

This basically reverts the changes of bug 1853519 to now use the setting
layout.css.always_underline_links instead of browser.underline_anchors.

Comment 6

[Hartmut Welpmann [:welpy-cw]]

Attachment: Test Mail for layout.css.always_underline_links - welpy-cw <[e-mail]> - 2024-02-05 2218.eml

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7f40045a2a93
Port bug 1664278: Expose an "always underline links" checkbox in settings. r=Paenglab