1878710 - Add translation support for all relevant HTML attributes

Status: RESOLVED FIXED

(Firefox :: Translations, enhancement)

Description

[Greg Tatum [:gregtatum]]

Bug 1819205 added support for translating attributes, but not all of them were covered. There are many other relevant attributes. An incomplete list includes:

input[value]
img[alt]
track[label]
[aria-label]
[aria-description]
[aria-label]
[aria-placeholder]
[aria-roledescription]
[aria-valuetext]
[aria-braillelabel]
[title]

Comment 1

[Greg Tatum [:gregtatum]]

I'm following up on https://bugzilla.mozilla.org/show_bug.cgi?id=1819205#c8

Andy: Do you have an example of: label for video tracks. I looked at the MDN page but was unclear of a live example of one.

placeholder and pattern attributes if the format needs localization

I don't think we would want to change pattern attributes, but the placeholder was already handled in the previous bug.

Comment 2

[Andy]

Sure, the label attribute can be found on the MDN page for the <track> element: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/track#label

<track kind="subtitles" src="sampleSubtitles_de.vtt" srclang="de" label="German" />

If it’s not defined, Firefox will show an entry without any text in the menu for subtitles.

Comment 3

[James Teh [:Jamie]]

I understand why this has been marked as an enhancement. It's technically not a "bug" in that this is just not something we support yet. However, I think it's important to note that this disproportionately impacts screen reader users (and potentially users of other assistive technology such as voice control) because there are often icons/images where the purpose is clear visually and translation isn't required, but the only exposure to accessibility tools is the alt text, aria-label, etc., making the control effectively unintelligible to those users. This will be treated as a defect by those users, even if we don't see it that way from an engineering standpoint.

Comment 4

[Greg Tatum [:gregtatum]]

Attachment: Bug 1878710 - Add more attribute support for translations; r?#translations-reviewers

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:gregtatum, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7822d39a6f79
Add more attribute support for translations; r=translations-reviewers,nordzilla

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/7822d39a6f79