1878858 - perma comm/mail/test/browser/content-tabs/browser_aboutSupport.js | String "undefined" should not be on the content tab's page - false == true

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mkmelin [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=446085861&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/NR3Xq0R8QT2EwAVdmA9z3A/runs/0/artifacts/public/logs/live_backing.log

---

New failure. Probably something needs porting

Comment 1

[Magnus Melin [:mkmelin]]

Something from https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=9f16b642b137c1390a012556c58e9f957a816ef6

Comment 2

[Magnus Melin [:mkmelin]]

Confirmed by local backout this is from bug 1826412. Specifically https://hg.mozilla.org/mozilla-central/rev/a5f0b8602ce1
I don't understand why.
Adding https://hg.mozilla.org/mozilla-central/diff/a5f0b8602ce17980ab43e5e46e7bff4f4bf6a844/toolkit/content/aboutSupport.js to mail/components/about-support/content/aboutSupport.js doesn't help, though it should probably be done.

Comment 3

[Magnus Melin [:mkmelin]]

Maybe Thunderbird builds are missing some ifdef for something. xref bug 1877660.

Tom, any ideas of what might be missing?

Comment 4

[Tom Ritter [:tjr]]

I'm sorry, I am not terribly familiar with these bits. My best guesses to trial/error would be:

It looks like it's saying "Undefined" shouldn't appear anywhere on about:support, but now it is". Does opening about:support on Thunderbird Nightly show you where it's saying "undefined"? Presumably in the new field I added - "Font Visibility Debug Info"

Prehaps the code I added in nsIGfxBase needs additional ifdefs/cases for Thunderbird, so it doesn't show up as undefined?

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: image.png

Screenshot

Comment 6

[Magnus Melin [:mkmelin]]

I would think it's not the test that is wrong, but showing a real issue (of some sort, like is gpu detection not working due to some ifdef?).

Comment 7

[Tom Ritter [:tjr]]

That patch (mine) doesn't do anything to GPU detection... If backout is showing that https://hg.mozilla.org/mozilla-central/rev/a5f0b8602ce1 is the source of the issue, I would try isolating it further. Specifically, does removing the row I added to the about:support page fix things?

Comment 8

[Magnus Melin [:mkmelin]]

Unfortunately that doesn't help.
But your suggestion made me explore this a bit more. This is the offending line: https://hg.mozilla.org/mozilla-central/rev/a5f0b8602ce1#l5.12 - if i remove it things are fine. The very odd thing here is that prop by itself is not a problem...
I found a "fix". It looks like something is only available properly on 2nd/3rd access.

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: Bug 1878858 - Fix fontVisibilityDeterminationStr. r=tjr

Comment 10

[Magnus Melin [:mkmelin]]

Does this ring any bells? ^^^

Comment 11

[Tom Ritter [:tjr]]

No, I don't know why that would happen... (Although I'm far from experienced in XPCOM.) Maybe if there was multi-threaded access...? Although I don't think that's happening here. The relevant code is all here...

You could try doing something simpler in GetFontVisibilityDeterminationStr, like copying how GetContentBackend(nsAString& aContentBackend) just assigns a string, and seeing if that changes the behavior...

Comment 12

[Geoff Lankow (:darktrojan)]

I think this line should be fontVisibilityDeterminationStr: "supportFontDetermination", since the L10n string is called support-font-determination not font-determination. That fixes the test.

Comment 13

[Magnus Melin [:mkmelin]]

I can confirm that, thanks!

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/193e6982f5a1
Fix fontVisibilityDeterminationStr. r=tjr

Comment 15

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/193e6982f5a1

Comment 16

[Intermittent Failures Robot]

3 failures in 4009 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 3

Platform and build breakdown:

• linux1804-64-qr: 2
  • opt: 2
• linux1804-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1878858&startday=2024-02-05&endday=2024-02-11&tree=all

Comment 17

[Magnus Melin [:mkmelin]]

Attachment: Bug 1878858 - Port bug 1826412: add supportFontDetermination to about:support. r=freaktechnik

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/970b0125b6a7
Port bug 1826412: add supportFontDetermination to about:support. r=freaktechnik