1879105 - Generalize SamsungXclipse920 workaround to all Xclipse GPUs

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1879105. Generalize SamsungXclipse920 workaround to all Xclipse GPUs.

We have reports of the same flickering that we were seeing on
Xclipse920 GPUs on Xclipse940. For now, let's just enable the workaround
on all Xclipse GPUs.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb4e8c43f195
Generalize SamsungXclipse920 workaround to all Xclipse GPUs. r=gfx-reviewers,nical

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9378765 [details]
Bug 1879105. Generalize SamsungXclipse920 workaround to all Xclipse GPUs.

Beta/Release Uplift Approval Request

• User impact if declined: Intermittent flickering for S24 users.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patches makes the work around apply more broadly. The code in the area is a little hairy so it's possible that it could end up not applying to both the S22 and S24. However, two people have closely read the code and it should be fine.
• String changes made/needed: n/a
• Is Android affected?: Yes

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/dedf6c75f1b3
Generalize SamsungXclipse920 workaround to all Xclipse GPUs. r=gfx-reviewers,nical a=graft

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/dedf6c75f1b3

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/eb4e8c43f195

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9378765 [details]
Bug 1879105. Generalize SamsungXclipse920 workaround to all Xclipse GPUs.

Rejecting release uplift request. After discussion, this will ride the train with Fx123 after it's been uplifted to Beta.

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9378765 [details]
Bug 1879105. Generalize SamsungXclipse920 workaround to all Xclipse GPUs.

Approved for 123 beta 9, thanks.

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/25dac1d6788c

Comment 10

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/25dac1d6788c