1879332 - Set the `inactive` RemoteTab attribute for inactive tabs

Status: RESOLVED FIXED

(Firefox for Android :: Tabs, enhancement, P2)

Description

[Mark Hammond [:markh] [:mhammond]]

Synced Tabs recently introduced a new attribute, inactive, which can be set if a device is not showing this tab by default but instead has it grouped under "inactive tabs".

Bug 1878310 introduced the ability for desktop to hide these "inactive" tabs from other devices - there's a screenshot in that bug which will give a better idea of the intent. We expect Firefox View to also support this flag in the short term. iOS sets this flag (currently on iOS Nightly) and this bug is for Fenix to do the same.

I looked into this but can't quite work out how to do it. Specifically, this line in RemoteTabsStorage can accept a new param, inactive (the default value is false, so not supplying it is fine). My problem is working out how to obtain this value for the given tab. I think that if we can obtain that value in SyncedTabsStorage then it should be easy, but I can't work out how to get that flag there either. Something something BrowserState something :)

Matt, you were suggested by JonA as a good person who might be able to help me come up with a patch here. Any suggestions?

CC Chris so he is aware of this feature; it would be a shame to have this spend too much time on release with only iOS support.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1879332 - ensure synced tabs includes the inactive property (#5941)

Comment 2

[BMO Github Automation]

Authored by https://github.com/mhammond
https://github.com/mozilla-mobile/firefox-android/commit/5b559a4e485fa859e43e5eb3bbca95abbcbdb151
[main] Bug 1879332 - ensure synced tabs includes the inactive property

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 9390004 [details] [review]
[mozilla-mobile/firefox-android] Bug 1879332 - ensure synced tabs includes the inactive property (#5941)

Beta/Release Uplift Approval Request

• User impact if declined: Lack of consistency how "inactive" tabs are handled between Android and iOS
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Risk is low and limited to synced tabs.
• String changes made/needed: None
• Is Android affected?: Yes

Comment 4

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1879332 - ensure synced tabs includes the inactive property (backport #5941) (#6013)

Comment 5

[Dianna Smith [:diannaS]]

Comment on attachment 9391116 [details] [review]
[mozilla-mobile/firefox-android] Bug 1879332 - ensure synced tabs includes the inactive property (backport #5941) (#6013)

Approved for Mobile 124.0rc2

Comment 6

[BMO Github Automation]

Authored by https://github.com/mhammond
https://github.com/mozilla-mobile/firefox-android/commit/5afe87a5bbb92f7ecf990a2fbc8095503a47c272
[releases_v124] Bug 1879332 - ensure synced tabs includes the inactive property