1879343 - Make it easier to close or dismiss tabs by adding close button to tab rows

Status: NEW

(Firefox :: Firefox View, enhancement, P3)

Description

[Nikki Sharpley (:nikkis) (she/her)]

The previous bug 1857298 adds a close button to the Open Tabs page/section. Now that the initial work is done, we should update all sections to have the same ease in closing or dismissing a tab without opening the context menu.

Comment 1

[Jonathan Sudiaman [:jsudiaman]]

I don't quite get this in terms of functionality. For example, in Recently Closed Tabs, we already have a "dismiss" button... having a "close" button wouldn't make a lot of sense because, well, they're already closed. In Tabs from other devices, I think we've already considered manipulating (i.e. closing) tabs from other devices out of scope. In History, there may be rows that match currently open tabs... but then it seems confusing in this case to show a close button for some rows in history, and not others. (Not to mention, this could get mistaken for a "Delete from History" button.)

If there was prior discussion about this or context I'm missing, please let me know!

Comment 2

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Figma designs

Comment 3

[Nikki Sharpley (:nikkis) (she/her)]

(In reply to Jonathan Sudiaman [:jsudiaman] from comment #1)

I don't quite get this in terms of functionality. For example, in Recently Closed Tabs, we already have a "dismiss" button... having a "close" button wouldn't make a lot of sense because, well, they're already closed. In Tabs from other devices, I think we've already considered manipulating (i.e. closing) tabs from other devices out of scope. In History, there may be rows that match currently open tabs... but then it seems confusing in this case to show a close button for some rows in history, and not others. (Not to mention, this could get mistaken for a "Delete from History" button.)

If there was prior discussion about this or context I'm missing, please let me know!

I believe for history the intention is to have the X button remove from history. The designs here detail the expected functionality for each section: https://www.figma.com/file/wP9MY9KJn9xqPf140lTvTv/Fx-View-Specs-2023?type=design&node-id=8084-200028&mode=design&t=MBoT9VEGXQh90Nx3-0

Apologies, the vocabulary (close/dismiss/remove) is what's confusing here. It could be either of those depending on the section.

Comment 4

[Sarah Clements [:sclements]]

We can put this as a lower priority for now since there is ongoing discussion in slack with UX/product about whether we should roll this out to Recently Closed Tabs and History section and we have other priorities atm.

Comment 5

[konyhéa]

Hii, is this still open and can. i pick it?