1857298 - Make it easier to close tabs on the "Open Tabs" page

Status: RESOLVED FIXED

(Firefox :: Firefox View, enhancement)

Description

[Jeff Muizelaar [:jrmuizel]]

It would be nice if there was a single X beside each tab that would let you close it. Having to click on the three dots and then "Close" is a pain when trying to close a lot of tabs.

Comment 1

[Sarah Clements [:sclements] | PTO until March 30th]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #0)

It would be nice if there was a single X beside each tab that would let you close it. Having to click on the three dots and then "Close" is a pain when trying to close a lot of tabs.

Hi, I'm curious if you use any of the list items in the 3-dot menu?

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Nope, I've never used the move tab functionality and if I wanted to copy a link I would right click instead of using the 3-dot menu.

Comment 3

[Sarah Clements [:sclements] | PTO until March 30th]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #2)

Nope, I've never used the move tab functionality and if I wanted to copy a link I would right click instead of using the 3-dot menu.

Thanks for the feedback.

Comment 4

[Amy Lee [:amylee] UX]

Adding an update here that it's in the backlog and we will be adding a close button to open tabs and eng will prioritize the work.

Comment 5

[Amy Lee [:amylee] UX]

Attachment: Spec for adding close button in Firefox View

Comment 6

[Amy Lee [:amylee] UX]

Comment on attachment 9365914 [details]
Spec for adding close button in Firefox View

https://www.figma.com/file/wP9MY9KJn9xqPf140lTvTv/Fx-View-Specs-2023?type=design&node-id=7988%3A168346&mode=design&t=lBXptMDNbgzG8wCo-1

Comment 7

[Amy Lee [:amylee] UX]

Attachment: Spec for adding close button in Firefox View

Comment 8

[Amy Lee [:amylee] UX]

Comment on attachment 9365914 [details]
Spec for adding close button in Firefox View

>https://www.figma.com/file/wP9MY9KJn9xqPf140lTvTv/Fx-View-Specs-2023?type=design&node-id=7988-168350&mode=design&t=JJmzlRRwHH1p7SrU-0

Comment 9

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1857298 - Add close button to open tabs in view r=#fxview-reviewers

Comment 10

[Nikki Sharpley (:nikkis) (she/her)]

Since we are removing "close tab" from the original tab context menu, which has telemetry to record panel items such are this are clicked, should we add telemetry for this new close button?

Comment 11

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: bug 1857298 - data request.rtf

Need info-ing jhirsch for a data review please. Cheers!

Comment 12

[Amy Lee [:amylee] UX]

(In reply to Nikki Sharpley (:nikkis) (she/her) from comment #10)

Since we are removing "close tab" from the original tab context menu, which has telemetry to record panel items such are this are clicked, should we add telemetry for this new close button?

Hi, yes I think we should add telemetry on the close button.

Thanks

Comment 13

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 9380179 [details]
bug 1857298 - data request.rtf

data-review+

---

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way? Click the documentation link provided in Q6 and ensure it is publicly accessible and does or will contain documentation for the data collection.

Yes.

2. Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Yes.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, nsharpley will monitor.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, interaction data.

5. Is the data collection request for default-on or default-off?

Default-on.

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

7. Is the data collection covered by the existing Firefox privacy notice?

Yes.

8. Does the data collection use a third-party collection tool?

No.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37ef0aa2d2b5
Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements

Comment 15

[Iulian Moraru]

Backed out for causing bc failures on browser_recentlyclosed_firefoxview.js.

• Push with failures

• Failure log
  There are also this type of TV jobs failures.

• Backout link

[task 2024-02-20T15:28:20.953Z] 15:28:20     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_recentlyclosed_firefoxview.js | Tab is visible in viewport - 
[task 2024-02-20T15:28:20.954Z] 15:28:20     INFO - Buffered messages finished
[task 2024-02-20T15:28:20.956Z] 15:28:20     INFO - TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/browser_recentlyclosed_firefoxview.js | Uncaught exception in test bound test_dismiss_tab - at chrome://mochikit/content/tests/SimpleTest/EventUtils.js:845 - TypeError: can't access property "getBoundingClientRect", aTarget is undefined
[task 2024-02-20T15:28:20.956Z] 15:28:20     INFO - Stack trace:
[task 2024-02-20T15:28:20.956Z] 15:28:20     INFO - synthesizeMouseAtCenter@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:845:14
[task 2024-02-20T15:28:20.956Z] 15:28:20     INFO - click_recently_closed_tab_item@chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/head.js:688:14
[task 2024-02-20T15:28:20.956Z] 15:28:20     INFO - dismiss_tab@chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/browser_recentlyclosed_firefoxview.js:32:10
[task 2024-02-20T15:28:20.956Z] 15:28:20     INFO - test_dismiss_tab/<@chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/browser_recentlyclosed_firefoxview.js:377:11
[task 2024-02-20T15:28:20.956Z] 15:28:20     INFO - async*withFirefoxView@resource://testing-common/FirefoxViewTestUtils.sys.mjs:143:22
[task 2024-02-20T15:28:20.956Z] 15:28:20     INFO - async*test_dismiss_tab@chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/browser_recentlyclosed_firefoxview.js:366:9
[task 2024-02-20T15:28:20.956Z] 15:28:20     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1139:26
[task 2024-02-20T15:28:20.956Z] 15:28:20     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1211:18
[task 2024-02-20T15:28:20.956Z] 15:28:20     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1353:14
[task 2024-02-20T15:28:20.956Z] 15:28:20     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1128:14
[task 2024-02-20T15:28:20.956Z] 15:28:20     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2024-02-20T15:28:20.956Z] 15:28:20     INFO - Leaving test bound test_dismiss_tab
[task 2024-02-20T15:28:20.957Z] 15:28:20     INFO - Entering test bound test_empty_states
[task 2024-02-20T15:28:20.957Z] 15:28:20     INFO - GECKO(1308) | [Parent 1308, GMPThread] WARNING: Failed to delete GMP storage directory: file /builds/worker/checkouts/gecko/dom/media/gmp/GMPServiceParent.cpp:1904
[task 2024-02-20T15:28:20.958Z] 15:28:20     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_recentlyclosed_firefoxview.js | Closed tab count after purging session history - 
[task 2024-02-20T15:28:20.958Z] 15:28:20     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_recentlyclosed_firefoxview.js | Closed tabs-from-closed-windows count after purging session history - 
[task 2024-02-20T15:28:20.959Z] 15:28:20     INFO - GECKO(1308) | [fluent-dom] While translating an element with fluent ID "firefoxview-recentlyclosed-empty-description" a child element of type "a" was removed. Either the fluent message does not contain markup, or it does not contain markup of this type.
[task 2024-02-20T15:28:20.960Z] 15:28:20     INFO - Console message: [JavaScript Warning: "[fluent-dom] While translating an element with fluent ID "firefoxview-recentlyclosed-empty-description" a child element of type "a" was removed. Either the fluent message does not contain markup, or it does not contain markup of this type." {file: "about:firefoxview#recentlyclosed" line: 0}]
[task 2024-02-20T15:28:20.961Z] 15:28:20     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_recentlyclosed_firefoxview.js | Firefox View tab exists - "[object XULElement]" == true - 
[task 2024-02-20T15:28:20.962Z] 15:28:20     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_recentlyclosed_firefoxview.js | Firefox View tab is hidden - true == true - 
[task 2024-02-20T15:28:20.963Z] 15:28:20     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_recentlyclosed_firefoxview.js | Firefox View tab is not in the list of visible tabs - -1 == -1 - 
[task 2024-02-20T15:28:20.963Z] 15:28:20     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_recentlyclosed_firefoxview.js | Firefox View tab is selected - true == true - 
[task 2024-02-20T15:28:20.964Z] 15:28:20     INFO - openFirefoxViewTab, waiting for complete readyState, visible and firefoxview-entered
[task 2024-02-20T15:28:20.964Z] 15:28:20     INFO - openFirefoxViewTab, ready resolved
[task 2024-02-20T15:28:20.965Z] 15:28:20     INFO - Not taking screenshot here: see the one that was previously logged
[task 2024-02-20T15:28:20.966Z] 15:28:20     INFO - TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/browser_recentlyclosed_firefoxview.js | undefined assertion name - Got "about:firefoxview#recentlyclosed", expected "about:firefoxview"
[task 2024-02-20T15:28:20.966Z] 15:28:20     INFO - Stack trace:
[task 2024-02-20T15:28:20.966Z] 15:28:20     INFO - chrome://mochikit/content/browser-test.js:test_is:1620
[task 2024-02-20T15:28:20.967Z] 15:28:20     INFO - chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/browser_recentlyclosed_firefoxview.js:test_empty_states/<:430
[task 2024-02-20T15:28:20.967Z] 15:28:20     INFO - resource://testing-common/FirefoxViewTestUtils.sys.mjs:withFirefoxView:143
[task 2024-02-20T15:28:20.967Z] 15:28:20     INFO - chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/browser_recentlyclosed_firefoxview.js:test_empty_states:428
[task 2024-02-20T15:28:20.967Z] 15:28:20     INFO - chrome://mochikit/content/browser-test.js:handleTask:1139
[task 2024-02-20T15:28:20.967Z] 15:28:20     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1211
[task 2024-02-20T15:28:20.968Z] 15:28:20     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1353
[task 2024-02-20T15:28:20.968Z] 15:28:20     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1128
[task 2024-02-20T15:28:20.968Z] 15:28:20     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-02-20T15:28:20.969Z] 15:28:20     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_recentlyclosed_firefoxview.js | Initial empty state header has the expected text. -

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4ed2e3e1ff2
Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32ca524f7abf
Fix lint failure @ browser/components/firefoxview/tests/browser/browser_opentabs_pinned_tabs.js a=lint-fix CLOSED TREE

Comment 18

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_parsable_css.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | missing chrome://browser/content/firefoxview/category-recentbrowsing.svg referenced from chrome://browser/content/firefoxview/firefoxview.css -

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b38d414bcdbc
Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb8d3011080f
Fix lint failure in browser/components/firefoxview/tests/browser/browser_opentabs_pinned_tabs.js. a=lint-fix CLOSED TREE

Comment 21

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b38d414bcdbc
https://hg.mozilla.org/mozilla-central/rev/eb8d3011080f