Closed Bug 1879503 Opened 3 months ago Closed 1 month ago

Update implementation of `getCookies` command to align with gecko default cookie behaviour

Categories

(Remote Protocol :: WebDriver BiDi, task, P2)

task
Points:
3

Tracking

(firefox126 fixed)

RESOLVED FIXED
126 Branch
Tracking Status
firefox126 --- fixed

People

(Reporter: Sasha, Assigned: Sasha)

References

(Blocks 1 open bug)

Details

(Whiteboard: [webdriver:m11][wptsync upstream][webdriver:relnote])

Attachments

(2 files, 1 obsolete file)

In the scope of bug1854580 we added one test which verifies the output of getCookies command against the cookies which are sent with network request. To ensure the correctness of the getCookies command, we should add more tests like this, e.g. just for a top-level document, for a cross-origin fetch() (with credentials) inside a top-level document, for a cross-origin image, etc.
And we should also update the implementation of getCookies command to work with network.cookie.cookieBehavior = 5, which is a default behaviour, instead of it equals 0 (right now this value is set as pref for CDP).

Priority: -- → P2
Whiteboard: [webdriver:backlog]
Depends on: 1880131
Assignee: nobody → aborovova
Status: NEW → ASSIGNED
Assignee: aborovova → nobody
Status: ASSIGNED → NEW
Summary: Add more tests for `getCookies` command with network events → Update implementation of `getCookies` command to align with gecko default cookie behaviour
Assignee: nobody → aborovova
Status: NEW → ASSIGNED
Depends on: 1884647
Attachment #9379982 - Attachment is obsolete: true
Points: --- → 3
Whiteboard: [webdriver:backlog] → [webdriver:m10]
Whiteboard: [webdriver:m10] → [webdriver:m11]
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/275fdabfd6cd
Do not send third-party cookies when it's not allowed by preferences. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/700fbf694ba4
[wdspec] Add tests for "storage.getCookies" command with network event. r=webdriver-reviewers,whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/45643 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m11] → [webdriver:m11], [wptsync upstream]
Upstream PR was closed without merging
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
Upstream PR merged by moz-wptsync-bot
Upstream PR merged by moz-wptsync-bot
Whiteboard: [webdriver:m11], [wptsync upstream] → [webdriver:m11][wptsync upstream][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: