1884647 - Fix partitioning in cookie commands

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P1)

Description

[Alexandra Borovova [:Sasha]]

Looking at the Puppeteer test failures for cookie related APIs, I've noticed two things which are probably wrong:

• when setting a same-site cookie with storage.setCookie command, we probably shouldn't add the partionKey in the originAttributes, otherwise cookies will not be available via document.cookie (and they probably should);
• For the browsing context where we have one page loaded, but we try to set a cookie with storage.setCookie on a different domain, we should be able to retrieve it with storage.getCookies for this context, but for this we shouldn't limit the lookup only for the hostname from this browsing context.

Comment 1

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1884647 - [bidi] Fix partitioning in cookie commands.

Comment 2

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1884647 - [wdpspec] Add more tests for partitioning.

Comment 3

[Alexandra Borovova [:Sasha]]

(In reply to Alexandra Borovova [:Sasha] from comment #0)

Looking at the Puppeteer test failures for cookie related APIs, I've noticed two things which are probably wrong:

• when setting a same-site cookie with storage.setCookie command, we probably shouldn't add the partionKey in the originAttributes, otherwise cookies will not be available via document.cookie (and they probably should);

It appeared that the fact that cookies with set partionKey in the originAttributes are not available with document.cookie is probably a bug on the platform side, see bug1884648. So this issue is excluded from this bug.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d377406231e1
[bidi] Fix partitioning in cookie commands. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/056ff7828670
[wdpspec] Add more tests for partitioning. r=webdriver-reviewers,jdescottes

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/45128 for changes under testing/web-platform/tests

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d377406231e1
https://hg.mozilla.org/mozilla-central/rev/056ff7828670

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot