1879580 - Wrong event order of network.responseCompleted for redirects

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P2)

Description

[Julian Descottes [:jdescottes]]

When request to URL A redirects to URL B, we currently have the following event order:

• beforeRequestSent for URL A
• responseStarted for URL A
• beforeRequestSent for URL B
• responseStarted for URL B
• responseCompleted for URL A
• responseCompleted for URL B

However, according to step 6 of https://whatpr.org/fetch/1540.html#concept-http-fetch, we should emit responseCompleted for URL A before we start the redirected request. So the expected event order should be:

• beforeRequestSent for URL A
• responseStarted for URL A
• responseCompleted for URL A
• beforeRequestSent for URL B
• responseStarted for URL B
• responseCompleted for URL B

Comment 1

[Julian Descottes [:jdescottes]]

Technically speaking, we are emitting responseCompleted when the input stream for the response is closed, and this will only happen when the response of the redirected request is received. However, we can detect that we have a redirect and force to emit responseCompleted earlier.

Comment 2

[Julian Descottes [:jdescottes]]

For the record here's a possible way to fix it: https://treeherder.mozilla.org/jobs?repo=try&revision=c92cdc8165fdf0ec86eb5036bccce5a2381cf58f

Comment 3

[Julian Descottes [:jdescottes]]

Increasing to 3 points because even though my patch on try works, it's not compatible with multiple sessions. A proper solution will require more work.

Comment 4

[Julian Descottes [:jdescottes]]

For reference, this blocks the puppeteer test "network Network Events Page.Events.RequestServedFromCache"

Comment 5

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1879580 - [bidi] Force event order of network.responseCompleted for redirects.

Comment 6

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1879580 - [wdspec] Add test for order of the network events in case of redirect.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f36e3ba36bca
[bidi] Force event order of network.responseCompleted for redirects. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/e4d8c448e836
[wdspec] Add test for order of the network events in case of redirect. r=webdriver-reviewers,jdescottes

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46635 for changes under testing/web-platform/tests

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f36e3ba36bca
https://hg.mozilla.org/mozilla-central/rev/e4d8c448e836

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot