1879692 - [WebGPU] 3 different crashes on a babylon.js demo (https://playground.babylonjs.com/#BCU1XR#0)

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect)

Description

[Mayank Bansal]

Use latest Nightly and enable webgpu
Go to https://playground.babylonjs.com/#BCU1XR#0
From the top-right, choose ""WEBGPU"

STR1
On the bar at the top, the "TS" should be in red. Click on it.
AR: https://crash-stats.mozilla.org/report/index/3b2398c2-001c-4e2b-8f3c-448e50240210
STR2
Click on the triangle "Run" button (maybe press multiple times)
AR: https://crash-stats.mozilla.org/report/index/83fafeea-31fa-4f2b-b206-80a3f0240210#tab-bugzilla , https://crash-stats.mozilla.org/report/index/2c5cef1a-0474-4ffc-8354-338db0240210#tab-bugzilla

Comment 1

[Mayank Bansal]

Attachment: about:support

Comment 2

[Erich Gubler [:ErichDonGubler] (he/him)]

I can reproduce this issue, and believe I've identified a fix. Will file a patch.

Comment 3

[Erich Gubler [:ErichDonGubler] (he/him)]

N.B. that I was only able to reproduce the mozilla::webgpu::ReadbackPresentCallback case. This seems to be the only crash signature associated with this bug within the last week.

Comment 4

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1879692: refactor(webgpu): s/PresentationData*/RefPtr<PresentationData> r=#webgpu-reviewers!

TODO: add thoughts

Comment 5

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1879692: chore(webgpu): remove `PresentationData::mBuffersLock` r=#webgpu-reviewers!,sotaro

TODO: add thoughts

Comment 6

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1879692: fix(webgpu): bail readback presentation if `get_mapped_range` fails r=#webgpu-reviewers!

Comment 7

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1879692: fix(webgpu): coerce valid. errors to internal in readback presentation r=#webgpu-reviewers!

Comment 8

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1879692: refactor(webgpu): always print WGPU errors in readback presentation r=#webgpu-reviewers!

Comment 9

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1879692: refactor(webgpu): clarify internal-ness of WGPU error logs in readback presentation r=#webgpu-reviewers!

Comment 10

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1879692: typo: s/aquires/acquires/ in `Mutex.h` r=#webgpu-reviewers!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfdc46044141
fix(webgpu): coerce valid. errors to internal in readback presentation r=webgpu-reviewers,nical
https://hg.mozilla.org/integration/autoland/rev/43e49edbfc56
refactor(webgpu): always print WGPU errors in readback presentation r=webgpu-reviewers,nical
https://hg.mozilla.org/integration/autoland/rev/19dc0337595b
fix(webgpu): bail readback presentation if `get_mapped_range` fails r=webgpu-reviewers,nical
https://hg.mozilla.org/integration/autoland/rev/4cc186ae41cf
refactor(webgpu): clarify internal-ness of WGPU error logs in readback presentation r=webgpu-reviewers,nical

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/dfdc46044141
https://hg.mozilla.org/mozilla-central/rev/43e49edbfc56
https://hg.mozilla.org/mozilla-central/rev/19dc0337595b
https://hg.mozilla.org/mozilla-central/rev/4cc186ae41cf

Comment 13

[Erich Gubler [:ErichDonGubler] (he/him)]

Mayank, can you confirm that this issue is fixed? I have some lagging patches I'd like to land before closing, but the actual OP issue should be fixed by now.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8cb47c02569
refactor(webgpu): s/PresentationData*/RefPtr<PresentationData> r=webgpu-reviewers,nical
https://hg.mozilla.org/integration/autoland/rev/b1f772cac771
chore(webgpu): remove `PresentationData::mBuffersLock` r=webgpu-reviewers,jimb
https://hg.mozilla.org/integration/autoland/rev/511dfc6ab20f
typo: s/aquires/acquires/ in `Mutex.h` r=webgpu-reviewers,nical

Comment 15

[Mayank Bansal]

(In reply to Erich Gubler [:ErichDonGubler] from comment #13)

Mayank, can you confirm that this issue is fixed? I have some lagging patches I'd like to land before closing, but the actual OP issue should be fixed by now.

I no longer get crashes. Thanks!

Comment 16

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/b8cb47c02569
https://hg.mozilla.org/mozilla-central/rev/b1f772cac771
https://hg.mozilla.org/mozilla-central/rev/511dfc6ab20f