1879791 - After Thunderbird 115, the minimum size of "Filter Rules" dialog is too large and the buttons extend off-screen the screen on low resolution

Status: NEW

(Thunderbird :: Filters, defect)

Description

[EarlgreyTea]

Attachment: Filter Rules dialog (v102 and v115).jpg

Attention:

This bug is not same as Bug 1365521. The bug, reported 7 years ago, refers to "Message Filters" dialog.
("Enabled" column exists in "Message Filters" dialog)
This bug reports for “Filter Rules” dialog.
This bug does not depends on Bug 298632.

Environment:

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:115.0) Gecko/20100101 Thunderbird/115.7.0
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:124.0) Gecko/20100101 Firefox/124.0 Thunderbird/124.0a1

Steps to reproduce:

1. Set the display resolution to "800 x 600".
2. Start Thunderbird.
3. Select menubar > Tools > Message Filters.
4. Select "New" button.

Actual results:

"Filter Rules" dialog appears larger than the display area.
Then, the "OK", "Cancel", "+", "-" buttons are off-screen and can't be clicked.

Expected result:

The dialog should be approximately the same width and height as Thunderbird 102.
Please see the attached image.
The left side of the image is Ver.102, and the right side is Ver.115 of the "Filter Rule" dialog. The red line indicates the range shown on the 800x600 display.

Additional Information:

After examining the regression range, it is clear that this bug is a regression of Bug 1826700.
https://hg.mozilla.org/comm-central/rev/6bcb80dfc6f4

The size of the block elements and the window is set in the file below, but the values do not seem to be appropriate.

• /mail/themes/shared/mail/filterEditor.css
• /mailnews/search/content/FilterEditor.xhtml

So I applied the userChrome.css below and got good results.

@-moz-document url-prefix("chrome://messenger/content/FilterEditor.xhtml") {
  #applyFiltersSettings {
    min-height: 128px !important;
    height: 128px !important;
  }

  #searchTermListBox {
    min-height: 120px !important;
    height: 120px !important;
  }

  #filterActionsBox {
    min-height: 100px !important;
    height: 100px !important;
  }

  #FilterEditor {
    min-width: 560px !important;
    min-height: 520px !important;
  }
}

Comment 1

[Wayne Mery (:wsmwk)]

Magnus, is it possible to sort out this regression from your patch in bug 1826700? Or does it require large changes in filter UI?

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: WIP__Bug_1879791___filterEditor_800x600.diff

I tried the suggestion, but it's still not very good at 800x600. Something is making the width larger than it should be for this situation, and the dialog is behaving oddly when trying to resize.

Comment 3

[Anje]

Tested in Windows 10 OS
Screen resolution 1920 x 1080 scale 100%

I am able to see all the 'filter creation window' ok, but another user reported a problem in Support Forum.
But these are my findings on my desktop computer.

**Tested version 128.10.0esr **
Message Filters
Select 'New' or 'Edit'
The 'Filter Rules' window size can not be altered. So if this is visible in it's entirety you are ok, but for some users this presents a problem as it cannot be resized.

I was trying to discover what size I an seeing for the 'Filter Rules' window, so I did this:
It's easier to force the Message Filter window to set about same size as the minimum 'Filter Rules' window, I can then see this in xulstore.json
"chrome://messenger/content/FilterListDialog.xhtml":{"filterListDialog":{"screenX":"48","screenY":"158","width":"916","height":"640"}}

So I presume this means my 'Filter Rules' window is this about size: width":"916","height":"640"

Checked situation in beta 139.0b3
Message Filters
Select 'New' or 'Edit'
The 'Filter Rules' window size can be increased in height and width, but not reduced as a minimum has been set.
This may present an issue if user cannot reduce height and/or width in order to make visible.
But what is that minimum size I'm seeing ?

It's easier to force the Message Filter window to set about same size as the minimum 'Filter Rules' window, I can then see this in xulstore.json
chrome://messenger/content/FilterListDialog.xhtml":{"filterListDialog":{"screenX":"408","screenY":"67","width":"width":"917","height":"640"}}

I presume this means my 'Filter Rules' window is this about size for minimum: "width":"917","height":"640" ?

So that shows my minimum size is probably the same for both versions.

New report in Support Forum where user cannot create a filter because there is no access to bottom buttons and window canot be resized.
https://support.mozilla.org/en-US/questions/1511973