1879805 - [win11] Some button text is not visible with High Contrast Night Sky enabled

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: HCM.gif

Found in

• 123.0b9

Affected versions

• 124.0a1 (2024-02-11)
• 123.0b9
• 122.0.1

Tested platforms

• Affected platforms: Windows 11x64
• Unaffected platforms: Ubuntu 22, macOS 12

Preconditions

• Night Sky High Contrast system theme enabled

Steps to reproduce

1. Open Profile Manager or About Firefox window to update Firefox.
2. Cycle through the Profile buttons or observe the Restart to Update button.

Expected result

• The button text is readable.

Actual result

• The button text is not readable.

Regression range

• Last good revision: 14364903b3513c984be3affb09c263c89bd313c6
  First bad revision: 5f1ebbf346712cdc7542680ad9b5509717872d9f
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=14364903b3513c984be3affb09c263c89bd313c6&tochange=5f1ebbf346712cdc7542680ad9b5509717872d9f

Additional notes

• Attached a screen recording.
• This applies to keyboard-selected buttons!

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1789214, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

I believe this is bug 1879386.

Comment 3

[Ciprian Georgiu, Desktop QA]

Emilio, it seems that the Bug 1879386 didn't resolve this issue as well. I am still able to reproduce the bug described in comment 0 on latest Nightly 127.0a1 with Win 11. Can you please take a look?

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1879805 - Use appropriate system colors for windows buttons. r=#theme!

So that they work properly in HCM.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e2e3736640f
Use appropriate system colors for windows buttons. r=desktop-theme-reviewers,Itiel

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7e2e3736640f

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox127 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9400981 [details]
Bug 1879805 - Use appropriate system colors for windows buttons. r=#theme!

Beta/Release Uplift Approval Request

• User impact if declined: Fixes contrast issues in HCM
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): non-trivial CSS change but windows-specific, and mostly HCM-specific...
• String changes made/needed: none
• Is Android affected?: No

Comment 9

[Ciprian Georgiu, Desktop QA]

I have verified this issue as fixed on latest Nightly 128.0a1 with Win 11. Tested with "Dusk" and "Night sky" high contrast themes.

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9400981 [details]
Bug 1879805 - Use appropriate system colors for windows buttons. r=#theme!

That feels a bit risky for a regression we have already shipped multiple releases with, let's have it ride the 128 train, thanks.

Comment 11

[Ciprian Georgiu, Desktop QA]

Closing this as verified fixed per my previous verification since the patch is not going to be uplifted in Beta as well.