1879873 - Always use ffmpeg's FFT code for the Web Audio API FFT needs

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Paul Adenot (:padenot)]

It has fast code for everything we intend to support and more ISA if need be, and we vendor it.

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1879873 - Remove kiss fft and openmax dl. r?karlt

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1879873 - Remove MOZ_LIBAV_FFT. r?karlt

We have some time to use av_fft.h, after which we'll have to use tx.h directly.
It's not hard to update.

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1879873 - Fix misc warning in FFT code. r?karlt

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1879873 - Directly use tx instead of the older avfft interface. r?karlt

Comment 5

[Paul Adenot (:padenot)]

Attachment: Bug 1879873 - Scale the inverse FFT result using tx instead of pre- or post-processing the data. r?karlt

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0aad3393b572
Remove kiss fft and openmax dl. r=karlt,sylvestre
https://hg.mozilla.org/integration/autoland/rev/5147903580b8
Remove MOZ_LIBAV_FFT. r=karlt
https://hg.mozilla.org/integration/autoland/rev/71824d88e1cd
Fix misc warning in FFT code. r=media-playback-reviewers,alwu
https://hg.mozilla.org/integration/autoland/rev/13edc1b203a7
Directly use tx instead of the older avfft interface. r=karlt,media-playback-reviewers
https://hg.mozilla.org/integration/autoland/rev/1d36088485a4
Scale the inverse FFT result using tx instead of pre- or post-processing the data. r=karlt

Comment 7

[Serban Stanca [:SerbanS]]

Backed out for causing bustages in FFmpegLibWrapper.h.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/media/platforms/ffmpeg/FFmpegLibWrapper.h:215:25: error: declaration of 'int (* mozilla::FFmpegLibWrapper::av_tx_init)(AVTXContext**, void (**)(AVTXContext*, void*, void*, ptrdiff_t), AVTXType, int, int, const void*, uint64_t)' [-fpermissive]

Comment 8

[Norisz Fay [:noriszfay]]

There's another failure caused by this bug. Log here

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c947114da80
Remove kiss fft and openmax dl. r=karlt,sylvestre
https://hg.mozilla.org/integration/autoland/rev/9973c75413d6
Remove MOZ_LIBAV_FFT. r=karlt
https://hg.mozilla.org/integration/autoland/rev/2e5121a988a8
Fix misc warning in FFT code. r=media-playback-reviewers,alwu
https://hg.mozilla.org/integration/autoland/rev/9b17ac4800c6
Directly use tx instead of the older avfft interface. r=karlt,media-playback-reviewers
https://hg.mozilla.org/integration/autoland/rev/e519654e5d8b
Scale the inverse FFT result using tx instead of pre- or post-processing the data. r=karlt

Comment 10

[Cristian Tuns]

Backed out for causing reftest failures

• Backout link
• Push with failures
• Failure Log
• Failure line: SUMMARY: AddressSanitizer: bad-malloc_usable_size /builds/worker/fetches/llvm-project/compiler-rt/lib/asan/asan_malloc_win.cpp:70 in _msize

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cff6a02ad4ee
Remove kiss fft and openmax dl. r=karlt,sylvestre
https://hg.mozilla.org/integration/autoland/rev/74fa25299c53
Remove MOZ_LIBAV_FFT. r=karlt
https://hg.mozilla.org/integration/autoland/rev/7c71c3d1a738
Fix misc warning in FFT code. r=media-playback-reviewers,alwu
https://hg.mozilla.org/integration/autoland/rev/9b4ea6ecadd1
Directly use tx instead of the older avfft interface. r=karlt,media-playback-reviewers
https://hg.mozilla.org/integration/autoland/rev/2356949f5c6d
Scale the inverse FFT result using tx instead of pre- or post-processing the data. r=karlt

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cff6a02ad4ee
https://hg.mozilla.org/mozilla-central/rev/74fa25299c53
https://hg.mozilla.org/mozilla-central/rev/7c71c3d1a738
https://hg.mozilla.org/mozilla-central/rev/9b4ea6ecadd1
https://hg.mozilla.org/mozilla-central/rev/2356949f5c6d

Comment 13

[Mayank Bansal]

8% improvement on AWFY-webaudio-Convolution reverb