Enable Rust Suggest by default
Categories
(Firefox :: Address Bar, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox124 | --- | fixed |
People
(Reporter: adw, Assigned: adw)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
(Whiteboard: [sng])
Attachments
(1 file)
As the final step to enabling the Rust backend for Suggest by default, we need to flip the quicksuggest.rustEnabled pref.
|
||
Updated•5 months ago
|
|
Assignee | |
Comment 1•5 months ago
|
||
This turned out to be a huge pain.
Many tests didn't work with the Rust backend. Generally I tried to keep tests
and tasks that truly need the JS backend, and I skip them when Rust is enabled.
I also added checks for quickSuggestRustEnabled so that tests don't assume the
Rust backend is enabled. I don't want to remove anything related to the JS
backend until the Rust backend is shipped in Release and we're confident we
don't need the JS backend anymore.
Also, browser tests didn't work properly because by the time
QuickSuggestTestUtils.ensureQuickSuggestInit() runs, the Rust backend has
already initialized, and _test_remoteSettingsConfig is not defined. To fix
that, I added a new _test_setRemoteSettingsConfig() function that recreates
the store with the new RS test config.
I also added some new helpers for generating remote settings data and for making
expected results in xpcshell tests.
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b0b34dab81d5 Enable Rust Suggest by default. r=daisuke
|
||
Comment 3•4 months ago
|
||
| bugherder | ||
Description
•