Figure out what to do with the Suggest impression-caps feature
Categories
(Firefox :: Address Bar, task, P3)
Tracking
()
People
(Reporter: adw, Unassigned)
References
Details
A number of Suggest tests have skip-if = ["true"] because they don't make sense with Rust enabled. We should figure out what to do with them. Some of them can probably be deleted because they test things that won't be implemented in Rust (legacy telemetry for example). Some of them test features that aren't yet implemented in Rust (impression caps, position in suggestions) and it's not clear if we still need them.
|
Reporter | |
Comment 1•1 year ago
|
||
Re: test_weather_keywords.js: Bug 1832912 added skip-if = ["verify"] to it because it can time out in verify mode. There are two reasons it takes so long: (1) it's a very thorough test that takes a long time even in non-verify mode, (2) due to add_tasks_with_rust(), each task is run twice, once with Rust enabled and once with it disabled. We should not delete this test, but once the JS backend and add_tasks_with_rust() are removed, it should take half as long. At that point we should remove the skip-if and see if it still times out. If it does, we should either add requesttimeoutfactor to its xpcshell.toml entry or split the test up.
|
|
Reporter | |
Comment 2•10 months ago
|
||
A bunch of legacy telemetry tests are being removed/modified in bug 1925355 (thanks Florian!)
|
|
Reporter | |
Comment 3•6 months ago
|
||
The only remaining skipped test is test_quicksuggest_impressionCaps.js, and we need to figure out what to do with Suggest's impression-caps feature in general. It's currently implemented in JS, was only ever enabled in experiments, and hasn't been used in years. If we need it again, we'd probably want to reimplement it in the Rust component. So most likely we should just remove the feature (and the test) entirely.
Description
•