1880295 - Fx VPN promo regions list is out of date

Status: RESOLVED DUPLICATE of bug 1858584

(Firefox :: Messaging System, defect, P1)

Description

[Hanna Alemu [:hanna_a]]

We'd like to keep the lists in Firefox in sync with the bedrock lists if there are changes. This ensures that we show the VPN promo on about:preferences#moreFromMozilla to the correct regions.

Github VPN regions lists: https://github.com/mozilla/bedrock/blob/a564fc12717f181529a1a4fa5afc0b83b1c80482/bedrock/settings/base.py#L1765
Lists and pref to update in MC: https://searchfox.org/mozilla-central/rev/2a286f214c783ff919d802c23a92e54bbf7411b9/browser/app/profile/firefox.js#2042
https://searchfox.org/mozilla-central/source/toolkit/modules/BrowserUtils.sys.mjs#504

The goal of this bug is to setup a script in Mozilla central that automatically fetches the base.py file in the github repo, and updates and commits the changes to mc if there are any differences. We'd like to watch for changes in VPN_COUNTRY_CODES, VPN_EXCLUDED_COUNTRY_CODES, and other relevant lists.

We're doing a similar script in https://bugzilla.mozilla.org/show_bug.cgi?id=1859302 , for reference.

Comment 1

[Punam Dahiya [:pdahiya]]

NI @vtay for feedback on prioritizing VPN infrastructure work

Comment 2

[Vtay]

I would recommend WontFix as I dont foresee us adding more countries/regions in the near future.

If we do, we can reopen this bug.

Comment 3

[Santiago]

Hi! We have launched the VPN in a bunch of new countries in Mid 2023. Can we add them please?

BG Bulgaria
CY Cyprus
CZ Czech Republic
DK Denmark
EE Estonia
HR Croatia
HU Hungary
LT Lithuania
LU Luxembourg
LV Latvia
MT Malta
PL Poland
PT Portugal
RO Romania
SI Slovenia
SK Slovakia

Also, we are planning to launch to a bunch of new countries in Q3/Q4 this year. I'm happy to file a ticket then, but automagically sync'ing with the Bedrock list would be a more scalable way to do this.

Comment 4

[Vtay]

@hanna A, could we prioritize in our next triage please?

Many thanks

Comment 5

[Hanna Alemu [:hanna_a]]

Thanks for letting us know @Santiago! We'll prioritize this bug in our triage.

Comment 6

[Hanna Alemu [:hanna_a]]

Hi @Santiago, these regions were added to MC in november with this patch: https://phabricator.services.mozilla.com/D192860#inline-1072709. The VPN promo does show for them currently. Since the changes to the bedrock lists are not frequent, please feel free to file bugs to update the MC lists and we'll update them as needed. The effort to create automatic updates seems like overkill for now, but we can consider doing it in the future if these types of changes are frequent. Thanks!