Selection abruptly collapses in GitHub's commits view
Categories
(Core :: DOM: Selection, defect, P3)
Tracking
()
People
(Reporter: bloonyapprentice, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Steps to Reproduce
- Visit any GitHub repo's commit view, for example mozregression.
- Try to select the first 4 commits message,
i. first by clicking and dragging until the timestamp
ii. another one by clicking and dragging downward
Expected behaviour
Both the commit message and commit timestamp should be selected, similar to other browsers. I've tested on Microsoft Edge.
Actual behaviour
The selection abruptly collapses/deselect when extending the selection over the commit timestamp. After that, only the commit timestamp is selected. This causes the user to easily lose their selection if they drag their selection to the right.
Note
This does not seem to be a Firefox regression. It may be caused by GitHub's redesign and non-standard implementation.
On both browsers, selecting the first commit is surprising difficult. I have to resort to using Alt+Left Click and drag so that the selection includes the first commit.
|
Reporter | |
Comment 1•2 years ago
|
||
For comparison on how it looks on Edge.
|
||
Comment 2•2 years ago
|
||
We currently don't support select across shadow boundaries well. There is some work in progress, we can revisit this after bug 1867058 or maybe bug 1455893.
|
|
||
Updated•2 years ago
|
|
|
Reporter | |
Comment 3•2 years ago
|
||
This bug was unknowingly fixed since bug 1867058 was resolved.
This is verified by mozregression using the --find-fix option:
35:52.08 INFO: No more integration revisions, bisection finished.
35:52.08 INFO: First good revision: ca6c1077eb877da6f475c18052a229ea8484460e
35:52.08 INFO: Last bad revision: d4fa0d22768b546122ab141619841094150382ca
35:52.08 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d4fa0d22768b546122ab141619841094150382ca&tochange=ca6c1077eb877da6f475c18052a229ea8484460e
Description
•