1880539 - Refactor firefoxview/syncedtabs.mjs to make business logic more reusable

Status: RESOLVED FIXED

(Firefox :: Sidebar, task)

Description

[Sarah Clements [:sclements]]

We have shared business logic already in the firefox-view-tabs-setup-manager.sys.mjs but there is more we can potentially extract to be able to create new synced tabs component that will render slightly different lists in sidebar vs Tabs from Other Devices and Recent Browsing in firefoxview. We may be able to use a reactive controller or context in lit. We ultimately want to end up with SyncedTabsSidebar extends MozLitElement whereas SyncedTabsView extends ViewPage, and (potentially) SyncedTabsRecentBrowsing extends ViewPage.

Comment 1

[Sarah Clements [:sclements]]

While you're in the syncedtabs.mjs file, if you can remove this dead code that'd be appreciated.

Comment 2

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 1880539 - Refactor firefoxview/syncedtabs.mjs to make business logic more reusable r?#fxview-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2092d43bfaae
Refactor firefoxview/syncedtabs.mjs to make business logic more reusable r=fxview-reviewers,nsharpley,sclements

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser/components/firefoxview/tests/browser/<...>

Backout link: https://hg.mozilla.org/integration/autoland/rev/7343078a368c7afc58db7d3236d03fcdca07b1fd

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/browser_firefoxview_tab.js

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67e5ff4a7d46
Refactor firefoxview/syncedtabs.mjs to make business logic more reusable r=fxview-reviewers,nsharpley,sclements

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/67e5ff4a7d46