1880586 - newtab npm bundle command generates different bundle on windows

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Shane Hughes [:aminomancer]]

D201139 seems to have introduced a regression where building the newtab bundle on windows yields a different result than on mac/linux.
You can test it with cd browser/components/newtab && "../../../mach" npm install
Reverting the changes to the webpack config and resourceUriPlugin.js before bundling also eliminates the diff.

I ran a bisection to double check: Bug 1878731, https://phabricator.services.mozilla.com/D201139

The issue seems to be because the ResourceUriPlugin produces wrong URLs on windows, mixing forward slashes and back slashes, because it substitutes a windows path (forward slashes) for a substring of a URL (back slashes):

// resourceUriPlugin.js:ResourceUriPlugin::apply

// before the patch
pathname :>>  C:\mozilla-git\mozilla-unified-2\browser\components\newtab\common\Actions.sys.mjs
pathname :>>  C:\mozilla-git\mozilla-unified-2\browser\components\newtab\common\Dedupe.sys.mjs

// after the patch
pathname :>>  C:\mozilla-git\mozilla-unified-2\browser\components\newtab\common/Actions.sys.mjs
pathname :>>  C:\mozilla-git\mozilla-unified-2\browser\components\newtab\common/Dedupe.sys.mjs

Since the try-runner.js runs on linux, any time we submit a patch from windows, it will get backed out (see bug 1880371 for example), unless we first discard the changes to activity-stream.bundle.js

A simple fix is to reform the path from the URL before using it. path.join knows how to handle slashes on Windows.

Comment 1

[Shane Hughes [:aminomancer]]

Attachment: Bug 1880586 - Fix newtab webpack resource URI discrepancy on Windows. r=#omc-reviewers,Standard8

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1878731

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1878731

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a7089e73d4c
Fix newtab webpack resource URI discrepancy on Windows. r=omc-reviewers,emcminn,thecount

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0a7089e73d4c

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:aminomancer, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.