1880371 - Shopping feature reminder includes brand styling in the main window

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Mark Striemer [:mstriemer]]

Attachment: panel-issue.png

STR
0. Enable shopping

1. Go to a shopping page
2. Click the shopping page action icon until the reminder panel shows up
3. Open the shield menu

Expected results: It look normal
Actual results: The heading styling has changed

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: panel-that-causes-issue.jpg

Comment 2

[Shane Hughes [:aminomancer]]

Attachment: Bug 1880371 - Don't leak unscoped styles into the browser chrome. r=#omc-reviewers,mstriemer

Comment 3

[Shane Hughes [:aminomancer]]

[Tracking Requested - why for this release]: This is a pretty nasty regression, and we're planning to use this feature callout surface throughout 123. So at this point I think the best case scenario is to squeeze this patch into the dot release, which I'll provide a dedicated patch for.

Comment 4

[Ed Lee :Mardak]

Was this regressed by bug 1849362 when adding the import in 119 or something more recent with moving files around?

Comment 5

[Shane Hughes [:aminomancer]]

I think it first became noticeable more recently with bug 1838939. But even back in 119 it was probably doing something it shouldn't have, since the reason the import was added was to get the standard link colors in about:welcome. So we were probably overriding link colors, but that'd be harder to notice without a custom theme or something.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox123 (beta). However, the bug still has low severity.

:aminomancer, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 7

[Shane Hughes [:aminomancer]]

It's a bad S3, but still a cosmetic issue.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00db63edda4c
Don't leak unscoped styles into the browser chrome. r=omc-reviewers,desktop-theme-reviewers,jprickett

Comment 9

[Noemi Erli[:noemi_erli]]

Backed out changeset 00db63edda4c (Bug 1880371) for causing newtab failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=BiooeyjuQAKMva7cchLreA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=00db63edda4c2b7bbc6d046c5a1eb74576dfca54

Log: https://treeherder.mozilla.org/logviewer?job_id=447428671&repo=autoland&lineNumber=361

Backout: https://hg.mozilla.org/integration/autoland/rev/212accf726833e2442dd54855e187edaaff3c06e

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60482f9cc434
Don't leak unscoped styles into the browser chrome. r=omc-reviewers,desktop-theme-reviewers,jprickett

Comment 11

[Shane Hughes [:aminomancer]]

Filed bug 1880586 for the bundle test discrepancy between windows and unix. For now I've just discarded the newtab changes to ensure it passes on linux, which is the test environment for the newtab task.

Comment 12

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/60482f9cc434

Comment 13

[Shane Hughes [:aminomancer]]

Attachment: Bug 1880371 - Don't leak unscoped styles into the browser chrome, for 123.0.1.

Comment 14

[Shane Hughes [:aminomancer]]

Comment on attachment 9380585 [details]
Bug 1880371 - Don't leak unscoped styles into the browser chrome, for 123.0.1.

Beta/Release Uplift Approval Request

• User impact if declined: There will be a visual bug when feature callout messages are shown, causing panel headings to be too large. This request is for 123.0.1, but we'll hold off on launching new feature callout campaigns until the dot release.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The code just removes an unwanted stylesheet import and updates a test file. It should also graft cleanly as I rebased it onto mozilla-release.
• String changes made/needed:
• Is Android affected?: No

Comment 15

[Shane Hughes [:aminomancer]]

Reopening for the moment since we need to uplift this to 123.0.1

Comment 16

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly and Beta 124.0b1.

Comment 17

[Shane Hughes [:aminomancer]]

We decided to move the experiment to Fx 124 instead of 123.0.1. So, I am removing the uplift request.