1880633 - 4.17 - 2.54% wikipedia loadtime / wikipedia LastVisualChange + 4 more (Linux, OSX) regression on Tue February 6 2024

Status: RESOLVED WONTFIX

(Core :: Internationalization, defect)

Description

[Acasandrei Beatrice (needinfo me)]

Perfherder has detected a browsertime performance regression from push 187caa38d3490df8b32dbeaf8cce22e6fdcc634a. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
4%	wikipedia loadtime	linux1804-64-shippable-qr	bytecode-cached fission warm webrender	439.59 -> 457.91	Before/After
4%	wikipedia loadtime	linux1804-64-shippable-qr	fission warm webrender	455.57 -> 472.40	Before/After
3%	wikipedia loadtime	linux1804-64-shippable-qr	fission warm webrender	458.84 -> 472.99	Before/After
3%	wikipedia LastVisualChange	linux1804-64-shippable-qr	fission warm webrender	1,094.65 -> 1,123.63	Before/After
3%	wikipedia loadtime	macosx1015-64-shippable-qr	bytecode-cached fission warm webrender	350.48 -> 359.46	Before/After
3%	wikipedia LastVisualChange	linux1804-64-shippable-qr	bytecode-cached fission warm webrender	1,083.62 -> 1,111.18	Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 41479

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1824671

Comment 2

[Jonathan Kew [:jfkthame]]

It's possible the unicode-bidi update in bug 1881487 may help a bit here.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:m_kato, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[Makoto Kato [:m_kato]]

Actually, this is disabled on release channel

Comment 5

[Jonathan Kew [:jfkthame]]

There isn't a single bug or patch that we can say "fixed" this, but there have been a number of incremental improvements to the unicode-bidi crate itself and to the Gecko integration. Looking again at graphs like https://treeherder.mozilla.org/perfherder/graphs?highlightAlerts=1&highlightChangelogData=1&highlightCommonAlerts=0&replicates=0&series=autoland,3869653,1,13&timerange=7776000 it appears that by early March, we had regained most of the regression here.

As such, I think we should accept any residual change here, and close this report as not actionable any further at this point.