1880741 - [Flatpak] Update metainfo file to be compliant under appstreamcli validate

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[bbhtt]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:124.0) Gecko/20100101 Firefox/124.0

Steps to reproduce:

The thunderbird metainfo file needs to be pass validation with appstreamcli validate being run under flatpak-builder-lint https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#validation

RIght now it fails validation due to screenshots being not under the image tag.

See https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#screenshots

Comment 1

[bbhtt]

The change for this needs to be landed in the release branch also, so that when the next release build is pushed to Flathub, it does not fail.

Comment 2

[bbhtt]

Attachment: Bug 1880741 - Move screenshots in child tag images. r?rjl

This makes it pass validation with appstreamcli validate

See also https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-screenshots

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/57bbe45078e5
Move screenshots in child tag images. r=dandarnell

Comment 5

[bbhtt]

Attachment: Bug 1880741 - Move screenshots in child tag images. r?rjl

This makes it pass validation with appstreamcli validate

See also https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-screenshots

Original Revision: https://phabricator.services.mozilla.com/D202097

Comment 6

[Phabricator Automation]

Uplift Approval Request

• Needs manual QE test: no
• Code covered by automated testing: no
• Is Android affected?: no
• Fix verified in Nightly: no
• Steps to reproduce for manual QE testing: Run appstreamcli validate on the metainfo file
• String changes made/needed: No
• User impact if declined: None
• Risk associated with taking this patch: Low
• Explanation of risk level: Changes metainfo file

Comment 7

[Daniel Darnell [:dandarnell]]

Comment on attachment 9380717 [details]
Bug 1880741 - Move screenshots in child tag images. r?rjl

[Approval Request Comment]
User impact if declined: Flatpak push may break
Testing completed (on c-c, etc.): It has been landed on c-c
Risk to taking this patch (and alternatives if risky): Low

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9380717 [details]
Bug 1880741 - Move screenshots in child tag images. r?rjl

[Triage Comment]
Approved for beta

Comment 9

[Daniel Darnell [:dandarnell]]

Thunderbird 124.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/68564826e685

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9382423 [details]
Bug 1880741 - Move screenshots in child tag images. r?rjl

[Triage Comment]
Approved for esr115

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 115.8.1:
https://hg.mozilla.org/releases/comm-esr115/rev/c231aa9cf93b