1880848 - gradle deprecation warnings related to 9.0 compat

Status: NEW

(GeckoView :: General, task, P1)

Description

[Julien Cristau [:jcristau]]

geckoview builds currently say Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

Comment 1

[Julien Cristau [:jcristau]]

Attachment: Bug 1880848 - set {source,target}Compatibility in a `java` block for compatibility with gradle 9.0.

See https://docs.gradle.org/8.6/userguide/upgrading_version_8.html#java_convention_deprecation

Comment 2

[Julien Cristau [:jcristau]]

Attachment: Bug 1880848 - use archiveFile instead of archivePath for compatibility with gradle 9.0.

https://docs.gradle.org/8.6/dsl/org.gradle.api.tasks.bundling.AbstractArchiveTask.html#org.gradle.api.tasks.bundling.AbstractArchiveTask:archivePath

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6eb64352980
set {source,target}Compatibility in a `java` block for compatibility with gradle 9.0. r=geckoview-reviewers,owlish
https://hg.mozilla.org/integration/autoland/rev/cfa733c700c1
use archiveFile instead of archivePath for compatibility with gradle 9.0. r=geckoview-reviewers,owlish,nalexander

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f6eb64352980
https://hg.mozilla.org/mozilla-central/rev/cfa733c700c1

Comment 5

[Julien Cristau [:jcristau]]

Unassigning myself since I don't know whether/when I would get back to looking at the remaining warnings.

Comment 6

[[:owlish] 🦉 PST]

Hey Polly, I wonder if this would be a part of the monorepo cleanup project you are leading?

Comment 7

[Polly [:polly]]

hi! it's not on our bug list currently, but it does sound like an important thing to look at.

Comment 8

[Aaditya Dhingra [:adhingra]]

Attachment: Bug 1880848 - Fix warning: org.gradle.api.plugins.BasePluginConvention type has been deprecated.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/183c75902e40
Fix warning: org.gradle.api.plugins.BasePluginConvention type has been deprecated. r=android-reviewers,webcompat-reviewers,twisniewski,pollymce,nalexander

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/183c75902e40

Comment 11

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/183c75902e40

Comment 12

[[:owlish] 🦉 PST]

Hey Zac, since this bug is leave-open, just to make sure - after the three patches were merged, is this still an issue?

Comment 13

[Zac McKenney [:zmckenney]]

I looked at the PR's and it seems like this can be closed. I'll confirm with Aaditya and either close it or we'll add a note for remaining work.

Comment 14

[Aaditya Dhingra [:adhingra]]

There is one more deprecation left: The AbstractCompile.destinationDir property has been deprecated. which is related to apiLint Plugin. Removing this block of code compiles without any deprecation warnings but need to investigate further to see if this is something we can fix!

Comment 15

[[:owlish] 🦉 PST]

Hi Aaditya, are you actively working on it?

Comment 16

[Aaditya Dhingra [:adhingra]]

No, I initially gave it a few tries but didn't make any progress so unassigned myself from the bug!