1881065 - Hit MOZ_CRASH(attempt to subtract with overflow) at /third_party/rust/wgpu-hal/src/vulkan/command.rs:215

Status: VERIFIED FIXED

(Core :: Graphics: WebGPU, defect, P1)

Description

[Jason Kratzer [:jkratzer]]

Testcase found while fuzzing mozilla-central rev ad2add2f3c60 (built with: --enable-debug --enable-fuzzing).

Testcase can be reproduced using the following commands:

$ pip install fuzzfetch grizzly-framework
$ python -m fuzzfetch --build ad2add2f3c60 --debug --fuzzing  -n firefox
$ python -m grizzly.replay.bugzilla ./firefox/firefox <bugid>

Hit MOZ_CRASH(attempt to subtract with overflow) at /third_party/rust/wgpu-hal/src/vulkan/command.rs:215

    ==1127600==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 0x000000000000 (pc 0x7f0da32a97e5 bp 0x7f0d0e66fd00 sp 0x7f0d0e66fcf0 T1127698)
    ==1127600==The signal is caused by a WRITE memory access.
    ==1127600==Hint: address points to the zero page.
        #0 0x7f0da32a97e5 in MOZ_Crash /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:301:3
        #1 0x7f0da32a97e5 in RustMozCrash /mozglue/static/rust/wrappers.cpp:18:3
        #2 0x7f0da32a90db in mozglue_static::panic_hook::hb575022dec86804d /mozglue/static/rust/lib.rs:96:9
        #3 0x7f0da32a90db in core::ops::function::Fn::call::h7d4a387df286a759 /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/ops/function.rs:79:5
        #4 0x7f0da431e9e5 in _$LT$alloc..boxed..Box$LT$F$C$A$GT$$u20$as$u20$core..ops..function..Fn$LT$Args$GT$$GT$::call::hbc5ccf4eb663e1e5 /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/alloc/src/boxed.rs:2029:9
        #5 0x7f0da431e9e5 in std::panicking::rust_panic_with_hook::h095fccf1dc9379ee /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:783:13
        #6 0x7f0da431e6f8 in std::panicking::begin_panic_handler::_$u7b$$u7b$closure$u7d$$u7d$::h032ba12139b353db /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:649:13
        #7 0x7f0da431bc25 in std::sys_common::backtrace::__rust_end_short_backtrace::h9259bc2ff8fd0f76 /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/sys_common/backtrace.rs:171:18
        #8 0x7f0da431e48f in rust_begin_unwind /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:645:5
        #9 0x7f0da436a484 in core::panicking::panic_fmt::h784f20a50eaab275 /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/panicking.rs:72:14
        #10 0x7f0da436a542 in core::panicking::panic::hb837a5ebbbe5b188 /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/panicking.rs:144:5
        #11 0x7f0da257689d in wgpu_hal::vulkan::command::_$LT$impl$u20$wgpu_hal..CommandEncoder$LT$wgpu_hal..vulkan..Api$GT$$u20$for$u20$wgpu_hal..vulkan..CommandEncoder$GT$::clear_buffer::h5476655d7c533cdf /third_party/rust/wgpu-hal/src/vulkan/command.rs:215:26
        #12 0x7f0da2458f06 in wgpu_core::command::clear::_$LT$impl$u20$wgpu_core..global..Global$GT$::command_encoder_clear_buffer::h3fc5f76eff41609c /third_party/rust/wgpu-core/src/command/clear.rs:157:13
        #13 0x7f0da2458f06 in wgpu_bindings::server::Global::command_encoder_action::h6d5fc122b4c397fc /gfx/wgpu_bindings/src/server.rs:989:35
        #14 0x7f0da246253c in wgpu_server_command_encoder_action /gfx/wgpu_bindings/src/server.rs:1053:5
        #15 0x7f0d9c850dd9 in mozilla::webgpu::WebGPUParent::RecvCommandEncoderAction(unsigned long, unsigned long, mozilla::ipc::ByteBuf const&) /dom/webgpu/ipc/WebGPUParent.cpp:1348:3
        #16 0x7f0d9c85d66a in mozilla::webgpu::PWebGPUParent::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PWebGPUParent.cpp:492:80
        #17 0x7f0d9a9a8bfd in mozilla::gfx::PCanvasManagerParent::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PCanvasManagerParent.cpp:290:32
        #18 0x7f0d99ee6c4f in mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message const&) /ipc/glue/MessageChannel.cpp:1813:25
        #19 0x7f0d99ee39a2 in mozilla::ipc::MessageChannel::DispatchMessage(mozilla::ipc::ActorLifecycleProxy*, mozilla::UniquePtr<IPC::Message, mozilla::DefaultDelete<IPC::Message>>) /ipc/glue/MessageChannel.cpp:1732:9
        #20 0x7f0d99ee4622 in mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::ActorLifecycleProxy*, mozilla::ipc::MessageChannel::MessageTask&) /ipc/glue/MessageChannel.cpp:1525:3
        #21 0x7f0d99ee576f in mozilla::ipc::MessageChannel::MessageTask::Run() /ipc/glue/MessageChannel.cpp:1623:14
        #22 0x7f0d99204051 in nsThread::ProcessNextEvent(bool, bool*) /xpcom/threads/nsThread.cpp:1193:16
        #23 0x7f0d9920b02d in NS_ProcessNextEvent(nsIThread*, bool) /xpcom/threads/nsThreadUtils.cpp:480:10
        #24 0x7f0d99eede05 in mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:330:5
        #25 0x7f0d99e02f41 in RunHandler /ipc/chromium/src/base/message_loop.cc:363:3
        #26 0x7f0d99e02f41 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:345:3
        #27 0x7f0d991ff323 in nsThread::ThreadFunc(void*) /xpcom/threads/nsThread.cpp:370:10
        #28 0x7f0dad49866f in _pt_root /nsprpub/pr/src/pthreads/ptthread.c:201:5
        #29 0x7f0dadd3aac2 in start_thread nptl/pthread_create.c:442:8
        #30 0x7f0daddcc84f  misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
    
    UndefinedBehaviorSanitizer can not provide additional info.
    SUMMARY: UndefinedBehaviorSanitizer: SEGV /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:301:3 in MOZ_Crash
    ==1127600==ABORTING

Comment 1

[Jason Kratzer [:jkratzer]]

Attachment: Testcase

Comment 2

[Bugmon [:jkratzer for issues]]

Verified bug as reproducible on mozilla-central 20240220094730-ad2add2f3c60.
The bug appears to have been introduced in the following build range:

Start: 774cda5d71b6d972886316da5c27c63907d90e1d (20231205152628)
End: 91bda8b5915b84ed6533a6620f955f271dc5aac3 (20231205162846)
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=774cda5d71b6d972886316da5c27c63907d90e1d&tochange=91bda8b5915b84ed6533a6620f955f271dc5aac3

Comment 3

[Erich Gubler [:ErichDonGubler] (he/him)]

I have a fix up for review upstream at gfx-rs/wgpu#5282. After that is merged, we will need a WGPU update.

Comment 4

[BugBot [:suhaib / :marco]]

This bug has been marked as a regression. Setting status flag for Nightly to affected.

Comment 5

[Erich Gubler [:ErichDonGubler] (he/him)]

:jkratzner: This should be resolved now. I can no longer reproduce a crash on my local machine. Please confirm!

Comment 6

[Jason Kratzer [:jkratzer]]

(In reply to Erich Gubler [:ErichDonGubler] from comment #5)

:jkratzner: This should be resolved now. I can no longer reproduce a crash on my local machine. Please confirm!

I can confirm that this no longer reproduces on m-c rev 79823348e9cf.

Comment 7

[Bugmon [:jkratzer for issues]]

Verified bug as fixed on rev mozilla-central 20240304212558-7d0df3f2acae.
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.