1881232 - Put the unicode-bidi implementation of Bidi support behind a Nightly-only conditional for now

Status: RESOLVED FIXED

(Core :: Internationalization, task)

Description

[Jonathan Kew [:jfkthame]]

As we've seen some perf regressions related to bug 1824671, let's make the switch to the unicode-bidi implementation be Nightly-only for now, while investigating these issues.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1881232 - Restrict use of the Rust unicode-bidi implementation to Nightly builds for now. r=emilio

There are a few testcases that were affected by the switch in bidi implementations
(see patches 5 and 6 in bug 1824671), so we need to update the metadata to reflect
the differing behavior between Nightly and Beta/Release builds. These changes will
be reverted when we allow unicode-bidi to ride the train to Release.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf0a2b842aca
Restrict use of the Rust unicode-bidi implementation to Nightly builds for now. r=emilio

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/bf0a2b842aca

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/bf0a2b842aca

Comment 5

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1881232 - Restrict use of the Rust unicode-bidi implementation to Nightly builds for now.

There are a few testcases that were affected by the switch in bidi implementations
(see patches 5 and 6 in bug 1824671), so we need to update the metadata to reflect
the differing behavior between Nightly and Beta/Release builds. These changes will
be reverted when we allow unicode-bidi to ride the train to Release.

Original Revision: https://phabricator.services.mozilla.com/D202305

Comment 6

[Phabricator Automation]

Uplift Approval Request

• User impact if declined: small perf regression in bidi resolution
• Risk associated with taking this patch: minimal
• Explanation of risk level: reverts to using previous implementation
• Needs manual QE test: no
• Code covered by automated testing: yes
• Is Android affected?: yes
• Fix verified in Nightly: no
• Steps to reproduce for manual QE testing: n/a
• String changes made/needed: none

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/6baa11955f78