Closed
Bug 1881265
Opened 2 years ago
Closed 2 years ago
Enable ESLint recommended rule getter-return
Categories
(Developer Infrastructure :: Lint and Formatting, task, P3)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox125 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox125 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
The getter-return ESLint rule is useful because it catches cases where we miss returning values from getters.
In some cases this is expected (and we should make those explicit), but occasionally it can catch errors. It is also a recommended rule, so we feel it should be enabled across the tree by default.
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
Comment 3•2 years ago
|
||
Comment on attachment 9381799 [details]
Bug 1881265 - Enable ESLint recommended rule no-case-declarations globally, warning for existing cases. r?Mossop!
Revision D202320 was moved to bug 1881266. Setting attachment 9381799 [details] to obsolete.
Attachment #9381799 -
Attachment is obsolete: true
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/08ade4f5729b
Enable ESLint recommended rule getter-return. r=mossop,extension-reviewers,devtools-reviewers,omc-reviewers,nchevobbe,aminomancer,robwu
You need to log in
before you can comment on or make changes to this bug.
Description
•