1881266 - Enable ESLint recommended rules no-constant-condition and no-case-declarations, warning for existing failures

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Mark Banner (:standard8)]

As part of our work to finish rolling out the recommended rules for ESLint, this bug is for no-constant-condition and no-case-declarations.

There's quite a few errors for these currently (~800 combined) so to start rolling this out, I'd like to enable it as warnings in the places where it is currently failing, and errors everywhere else. This should help start to catch new cases, whilst the full roll-out continues.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1881266 - Enable ESLint recommended rule no-constant-condition globally, warning for existing cases. r?Mossop!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1881266 - Enable ESLint recommended rule no-case-declarations globally, warning for existing cases. r?Mossop!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82d14a7274ab
Enable ESLint recommended rule no-constant-condition globally, warning for existing cases. r=mossop,devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/8207f0d5ebaa
Enable ESLint recommended rule no-case-declarations globally, warning for existing cases. r=mossop

Comment 4

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/82d14a7274ab
https://hg.mozilla.org/mozilla-central/rev/8207f0d5ebaa