1881268 - [meta] Roll-out ESLint rule no-constant-condition to all areas

Status: NEW

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Mark Banner (:standard8)]

In bug 1881266 we are enabling the ESLint rule no-constant-condition. For existing failures, we are marking those as warnings, and so we should work to reduce the list of warnings down, and enable the rule as failing everywhere.

Comment 1

[Julian Descottes [:jdescottes]]

Just something I noticed during a recent review, with a recent (1 year ago) eslint change while (true) is now allowed. This is driven by the new default value for the checkLoops option: "allExceptWhileTrue". If we are fine with it, we can probably trim down the list of excluded files a bit.