Open Bug 1881496 Opened 2 months ago Updated 2 months ago

[meta] Enable ESLint rule no-shadow on production code

Categories

(Developer Infrastructure :: Lint and Formatting, task, P3)

Product:
Developer Infrastructure
Component:
Lint and Formatting
Type:
task

Tracking

(Not tracked)

People

(Reporter: standard8, Unassigned)

References

Details

(Keywords: meta)

We want to roll out the ESLint rule no-shadow to more places across the tree. We have seen cases that ESLint would have caught had it been enabled (e.g. bug 1875486), and we have always planned to roll this out wider.

Although this is currently enabled for browser/, browser mochitests and xpcshell-tests, there are still quite a few failures.

An initial step would be to investigate the current failures and figure out if there's anything that we do want to exclude from the rule, e.g. event might be a possible name to exclude.

We should also aim to enable builtinGlobals as that would help with cases such as bug 1875486.

Duplicate of this bug: 1316873
You need to log in before you can comment on or make changes to this bug.