1881582 - Change Clear and Manage items from address/credit card autocomplete dropdown to use generic autocomplete

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, enhancement)

Description

[Neil Deakin]

Remove the items from https://searchfox.org/mozilla-central/source/browser/extensions/formautofill/content/customElements.js :

• MozAutocompleteProfileListitemFooter
• MozAutocompleteProfileListitemClearButton

Use MozAutocompleteTwoLineRichlistitem instead.

Comment 1

[Neil Deakin]

Attachment: Bug 1881582, replace MozAutocompleteProfileListitemClearButton with an implementation based on the generic MozAutocompleteTwoLineRichlistitem type, r=#credential-management-reviewers

Comment 2

[Neil Deakin]

Attachment: Bug 1881582, replace the Manage button in the address/credit card autocomplete dropdown with a simpler implementation based on MozAutocompleteTwoLineRichlistitem, r=#credential-management-reviewers

Depends on D202747

Comment 3

[Neil Deakin]

Attachment: Bug 1881582, handle disabled richlistitems in autocomplete popup, r=mstriemer

Depends on D202748

Comment 4

[Neil Deakin]

Attachment: Bug 1881582, implement the address autofill warning on the popup as a separate row and remove the implementation based on the custom class MozAutocompleteProfileListitemFooter, r=#credential-management-reviewers

Depends on D202749

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02e295ea9b67
replace MozAutocompleteProfileListitemClearButton with an implementation based on the generic MozAutocompleteTwoLineRichlistitem type, r=credential-management-reviewers,fluent-reviewers,bolsson,tgiles,sgalich
https://hg.mozilla.org/integration/autoland/rev/6005be94c74e
replace the Manage button in the address/credit card autocomplete dropdown with a simpler implementation based on MozAutocompleteTwoLineRichlistitem, r=credential-management-reviewers,sgalich
https://hg.mozilla.org/integration/autoland/rev/17ae2064cb82
handle disabled richlistitems in autocomplete popup, r=mstriemer,reusable-components-reviewers
https://hg.mozilla.org/integration/autoland/rev/7e0133076c73
implement the address autofill warning on the popup as a separate row and remove the implementation based on the custom class MozAutocompleteProfileListitemFooter, r=credential-management-reviewers,fluent-reviewers,desktop-theme-reviewers,reusable-components-reviewers,mstriemer,bolsson,sgalich,dao

Comment 6

[Iulian Moraru]

Backed out for causing bc failures on browser_parsable_css.js.
So far, this only failed on OS X 10.15 WebRender opt.

• Push with failures

• Failure log

• Backout link

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/496f2f2ad959
replace MozAutocompleteProfileListitemClearButton with an implementation based on the generic MozAutocompleteTwoLineRichlistitem type, r=credential-management-reviewers,fluent-reviewers,bolsson,tgiles,sgalich
https://hg.mozilla.org/integration/autoland/rev/f2d5d0925cfd
replace the Manage button in the address/credit card autocomplete dropdown with a simpler implementation based on MozAutocompleteTwoLineRichlistitem, r=credential-management-reviewers,sgalich
https://hg.mozilla.org/integration/autoland/rev/c429c3d10f6a
handle disabled richlistitems in autocomplete popup, r=mstriemer,reusable-components-reviewers
https://hg.mozilla.org/integration/autoland/rev/3f9778571c70
implement the address autofill warning on the popup as a separate row and remove the implementation based on the custom class MozAutocompleteProfileListitemFooter, r=credential-management-reviewers,fluent-reviewers,desktop-theme-reviewers,reusable-components-reviewers,mstriemer,bolsson,sgalich,dao

Comment 8

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failure on autocomplete-item.css

Backout link: https://hg.mozilla.org/integration/autoland/rev/d28cce16aa12c7123d414062a9a66e29278cca2f
Log link: https://treeherder.mozilla.org/logviewer?job_id=451405503&repo=autoland&lineNumber=6705

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc9648a468f2
replace MozAutocompleteProfileListitemClearButton with an implementation based on the generic MozAutocompleteTwoLineRichlistitem type, r=credential-management-reviewers,fluent-reviewers,bolsson,tgiles,sgalich
https://hg.mozilla.org/integration/autoland/rev/98c71049a835
replace the Manage button in the address/credit card autocomplete dropdown with a simpler implementation based on MozAutocompleteTwoLineRichlistitem, r=credential-management-reviewers,sgalich
https://hg.mozilla.org/integration/autoland/rev/dabb7983c1c8
handle disabled richlistitems in autocomplete popup, r=mstriemer,reusable-components-reviewers
https://hg.mozilla.org/integration/autoland/rev/83209c4fd4a8
implement the address autofill warning on the popup as a separate row and remove the implementation based on the custom class MozAutocompleteProfileListitemFooter, r=credential-management-reviewers,fluent-reviewers,desktop-theme-reviewers,reusable-components-reviewers,mstriemer,bolsson,sgalich,dao

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/fc9648a468f2
https://hg.mozilla.org/mozilla-central/rev/98c71049a835
https://hg.mozilla.org/mozilla-central/rev/dabb7983c1c8
https://hg.mozilla.org/mozilla-central/rev/83209c4fd4a8