1881746 - NVDA and Voice Over will Focus on the Highlights first instead of the text from the PDF

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect)

Description

[Rares Doghi, Desktop QA]

Found in

• Nightly 125.0a1 (2024-02-23)

Affected versions

• Nightly 125.0a1 (2024-02-23)
• Beta 124.0b2
• Release 123

Affected platforms

• macOS

Preconditions:
Enable Voice Over

Steps to reproduce

1. Open any PDF in Firefox.
2. Enable the Highlight tool.
3. Highlight Any Random pieces of text from the PDF file.
4. Use Voice over to reach the First line of text from the PDF.

Expected result

• User should reach the text as if none of it is Highlighted.
  Voice Over should probably ignore the Highlights or when it reaches the Highlighted text it should say the text + the fact that its highlighted.

Actual result

• The Voice over will reach the Highlights first until the end of the document and then it will start reading from the First line.
  In a PDF where a user highlights multiple different rows of text, will be a bit harder for them to navigate through it with Voice over commands.

Regression range
Not a Regression

Comment 1

[James Teh [:Jamie]]

I might be missing something, but if I understand correctly, this bug and bug 1881743 seem to contradict each other somewhat. Can you clarify? Does VO read the highlight (as this bug suggests) or does it not (as bug 1881743 suggests)?

Comment 2

[Rares Doghi, Desktop QA]

@James, the problem here is that in a pdf with a lot of Highlights the user would have to go over them first before reaching the first line of text, Voice Over will not read the Highlights out loud at all as mentioned in bug 1881743, but it will focus those highlights when we Navigate through the PDF file with VO commands.

Comment 3

[James Teh [:Jamie]]

(In reply to Rares Doghi, Desktop QA from comment #2)

Voice Over will not read the Highlights out loud at all as mentioned in bug 1881743, but it will focus those highlights when we Navigate through the PDF file with VO commands.

Can you clarify what steps you're taking and what VO says in these situations? I'm still confused when you say that it won't read them out loud, but it will focus them if you use VO commands. If it doesn't read them out, what does it do when you use VO commands? And if it does read them out when you use VO commands, when doesn't it read them out?

I do follow your meaning regarding the order being wrong and that is definitely a bug that needs to be addressed.

Comment 4

[Rares Doghi, Desktop QA]

Attachment: VoiceOverOrder.mp4

Here is a screen recording of this issue, using voice over commands it will always go through each highlight first and then reach back for the text from the PDF, that is the main issue here.

For the second issue, Voice over will not read the Highlighted text, it reaches the Highlight but it will just say image, you are currently on an image, that is why I said it wont read the text out loud, instead of saying "image, you are currently on an image"

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:calixte, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 6

[Marco Castelluccio [:marco]]

Marking 115 and 123 as affected as this is a long standing issue with highlighted text.

Also bumping severity to S2 to match accessibility severity.

Comment 7

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Make the text layer focusable before the editors (bug 1881746) (#17790)

Comment 8

[Rares Doghi, Desktop QA]

So now its able to reach the text first if there is no Highlight on that row of text, but on rows with highlights, the highlight is focused first then the Menu button and then the Text from the beginning.

This is a bit weird because if only one word is highlighted and read by voice over, that word is read out of context but its not mentioning that its a highlighted word, after that its reading the toolbar menu button and then it starts reading the line of text with that highlighted word.

This is Verified as fixed in our latest Nightly build 126.0a1 (2024-03-28).

Comment 9

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 125.0b8.