Closed
Bug 1881995
Opened 7 months ago
Closed 5 months ago
Replace strings during atomization with a new string type which points to the corresponding atom
Categories
(Core :: JavaScript Engine, task, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
127 Branch
Tracking | Status | |
---|---|---|
firefox127 | --- | fixed |
People
(Reporter: alexical, Assigned: alexical)
References
(Depends on 1 open bug, Blocks 3 open bugs, Regressed 1 open bug)
Details
(Whiteboard: [sp3])
Attachments
(1 file)
Chromium does something similar. Basically when we atomize a string, in many cases we can replace that string in-line with a new string type which holds a pointer to the corresponding atom. Then, that atom can be cheaply looked up either in C++ or JIT code.
Assignee | ||
Comment 1•7 months ago
|
||
Updated•7 months ago
|
Assignee: nobody → dothayer
Status: NEW → ASSIGNED
Updated•7 months ago
|
Whiteboard: [sp3]
Updated•7 months ago
|
See Also: → https://mozilla-hub.atlassian.net/browse/SP3-738
Updated•7 months ago
|
Priority: -- → P2
Pushed by dothayer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ae6126131b6d Implement ForwardedAtoms and create them during atomization r=iain,sfink
Comment 3•5 months ago
|
||
Backed out for causing ThreadSanitizer failures @ HashFunctions.h
Backout link: https://hg.mozilla.org/integration/autoland/rev/9bd26787807b9a0edd824ca5149a4f0c6b38e4bf
Flags: needinfo?(dothayer)
Comment 4•5 months ago
|
||
Please land this after the next merge, especially now with the long weekend coming up :)
Pushed by dothayer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fa120d93961e Implement ForwardedAtoms and create them during atomization r=iain,sfink
Assignee | ||
Updated•5 months ago
|
Flags: needinfo?(dothayer)
Comment 6•5 months ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox127:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•