1881995 - Replace strings during atomization with a new string type which points to the corresponding atom

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Alex Thayer [:alexical] (she/her)]

Chromium does something similar. Basically when we atomize a string, in many cases we can replace that string in-line with a new string type which holds a pointer to the corresponding atom. Then, that atom can be cheaply looked up either in C++ or JIT code.

Comment 1

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1881995 - Implement ForwardedAtoms and create them during atomization r?iain

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae6126131b6d
Implement ForwardedAtoms and create them during atomization r=iain,sfink

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing ThreadSanitizer failures @ HashFunctions.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/9bd26787807b9a0edd824ca5149a4f0c6b38e4bf

Push with failures

Failure log ->SUMMARY: ThreadSanitizer: heap-use-after-free /builds/worker/workspace/obj-build/dist/include/mozilla/HashFunctions.h:268:28 in HashStringKnownLength<const unsigned char *>

Comment 4

[Jan de Mooij [:jandem]]

Please land this after the next merge, especially now with the long weekend coming up :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa120d93961e
Implement ForwardedAtoms and create them during atomization r=iain,sfink

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fa120d93961e

Comment 7

[Mayank Bansal]

10% improvement on AWFY-Jetstream2-OfflineAssembler-Average