1895678 - 7.54 - 4.26% pdfpaint colorspace_atan.pdf / pdfpaint bug1650302_reduced.pdf + 6 more (Linux, OSX, Windows) regression on Thu April 25 2024

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect, P2)

Description

[Acasandrei Beatrice (needinfo me)]

Perfherder has detected a talos performance regression from push fa120d93961efddd63d50135f03c55e75dac875a. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
8%	pdfpaint colorspace_atan.pdf	macosx1015-64-shippable-qr	e10s fission stylo webrender	406.01 -> 436.61
5%	pdfpaint colorspace_atan.pdf	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	482.31 -> 508.68
5%	pdfpaint colorspace_sin.pdf	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	403.70 -> 424.58
5%	pdfpaint colorspace_cos.pdf	windows10-64-shippable-qr	e10s fission stylo webrender-sw	387.21 -> 406.71
5%	pdfpaint colorspace_cos.pdf	macosx1015-64-shippable-qr	e10s fission stylo webrender	402.10 -> 421.98
5%	pdfpaint colorspace_atan.pdf	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	486.88 -> 510.62
4%	pdfpaint colorspace_sin.pdf	windows10-64-shippable-qr	e10s fission stylo webrender-sw	389.20 -> 406.24
4%	pdfpaint bug1650302_reduced.pdf	windows10-64-shippable-qr	e10s fission stylo webrender-sw	308.33 -> 321.47

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 77

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1881995

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1881995

Comment 3

[Alex Thayer [:alexical] (she/her)]

Still poking at this, but I feel like it's some kind of pathology in the benchmarking setup, because I can't reproduce this when I just try to render the file locally. If anything I see a slight improvement, but certainly not a 5% regression.

Comment 4

[Mayank Bansal]

Should this bug be closed given that it has been many months without progress, and bug 1936544 increased the threshold of alert to 6% (which means than only a fraction of the regressions would have caused this alert)?

Comment 5

[Iain Ireland [:iain]]

I think it's fine to close this.