1882080 - Firefox no longer opens after clicking Restart Firefox inside Mozilla Crash Reporter

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P3)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Found in

• 124.0b4

Affected versions

• 125.0a1 (2024-02-26)
• 124.0b4

Tested platforms

• Affected platforms: macOS 13 ARM, macOS 12
• Unaffected platforms: Windows 10x64, Lubuntu 22

Steps to reproduce

1. Open Firefox and type about:crashparent
2. Click to Restart Firefox inside Mozilla Crash Reporter

Expected result

• Firefox is restarted.

Actual result

• Firefox is not restarted.

Regression range

• Not reproducible with Firefox 124.0b3.
  Pushlog:
  https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?revcount=1000. Possible regressors: bug 1879816 or bug 1872920. If a more accurate regression range is needed please let me know.

Additional notes

• Attached a screen recording: link

Comment 1

[Brad Werth [:bradwerth] | Out until March 3]

I can reproduce this, but I can't get mozregression to do anything useful. I assume the restart behavior is based on some daemon watching the firefox process and a crash in a mozregression build doesn't trigger that. Either way, it's fairly unlikely that Bug 1879816 would prevent Firefox from starting. The change there was to our handling of modal mode, which happens to be used by the Restart Firefox dialog, but is not inherently tied to launching Firefox.

Comment 2

[Gabriele Svelto [:gsvelto]]

Onto this, I'll work on it tomorrow.

Comment 3

[Gabriele Svelto [:gsvelto]]

I've investigated this a bit and it's odd. It seems that when restarting Firefox posix_spawnp() doesn't interpret the ".." elements of the path (which is absolute, but has to go back three directories relative to where the crash reporter client is). The fix is rather straightforward fortunately.

Comment 4

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1882080 - Don't use double dots in the path used to restart Firefox on macOS r=afranchuk

Comment 5

[Gabriele Svelto [:gsvelto]]

Alex, you might want to check that this doesn't affect bug 1759175 before re-landing it.

Comment 6

[Alex Franchuk [:afranchuk]]

Yep, not a problem, we pop() the path.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a7ef455619c
Don't use double dots in the path used to restart Firefox on macOS r=afranchuk

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9a7ef455619c

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:gsvelto, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Gabriele Svelto [:gsvelto]]

Comment on attachment 9384110 [details]
Bug 1882080 - Don't use double dots in the path used to restart Firefox on macOS r=afranchuk

Beta/Release Uplift Approval Request

• User impact if declined: The crash reporter client won't restart Firefox on macOS
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Launch Firefox on macOS

2. Browse to about:crashparent
3. From the crash reporter client window press "Restart"
4. Firefox should restart

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This fixes a small regression introduced in bug 1872920, all the changes are within the crash reporter client and none in Firefox proper
• String changes made/needed: None
• Is Android affected?: No

Comment 11

[Dianna Smith [:diannaS]]

Comment on attachment 9384110 [details]
Bug 1882080 - Don't use double dots in the path used to restart Firefox on macOS r=afranchuk

Approved for 124.0b6

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/b9010ad44e93

Comment 13

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 125.0a1 (2024-02-28) and Firefox 124.0b6 treeherder build from comment 12 on macOS 12 Intel and macOS 14 ARM. Clicking the Restart Firefox inside Crash reporter will restart Firefox as expected.

Comment 14

[Gabriele Svelto [:gsvelto]]

(In reply to Alexandru Trif, Desktop QA [:atrif] from comment #13)

Verified fixed with Firefox 125.0a1 (2024-02-28) and Firefox 124.0b6 treeherder build from comment 12 on macOS 12 Intel and macOS 14 ARM. Clicking the Restart Firefox inside Crash reporter will restart Firefox as expected.

Thank you!

Comment 16

[Gabriele Svelto [:gsvelto]]

I had mistakenly forgot to flag ESR as being affected and thus failed to uplift the patch.

Comment 17

[Gabriele Svelto [:gsvelto]]

Comment on attachment 9384110 [details]
Bug 1882080 - Don't use double dots in the path used to restart Firefox on macOS r=afranchuk

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is a visible regression with a simple fix
• User impact if declined: The crash reporter client won't restart Firefox on macOS
• Fix Landed on Version: 125
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This has been in other release channels for a while and works fine

Comment 18

[Donal Meehan [:dmeehan]]

Comment on attachment 9384110 [details]
Bug 1882080 - Don't use double dots in the path used to restart Firefox on macOS r=afranchuk

Approved for 115.11esr.

Comment 19

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/a73696eed7aa

Comment 20

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I was able to replicate the issue on an affected Firefox 115.10.0esr build, using macOS 12.6.6 Intel.
Verified as fixed on Firefox 115.11.0esr build ID 20240506144012, using macOS 12.6.6 Intel. Clicking the Restart Firefox inside Crash reporter will restart Firefox as expected.