1882089 - Flip the "remote.active-protocols" default value to "1" after the Firefox 128 ESR release

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Right now Firefox enables both the CDP and WebDriver BiDi protocols via the remote.active-protocols preference.

After the 128 ESR release we do not want to have CDP enabled by default anymore, which would require CDP clients to set this preference to 2.

This change would also include writing a blog post most likely on fxdx.dev to explain the strategy behind it. As best this should be send out (at latest) together with the Firefox 127 release to give users time to adapt their client code and CI pipelines.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Attachment: Bug 1882089 - [remote] Update tests for explictly enabling the CDP protocol if needed.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Attachment: Bug 1882089 - [remote] Do not enable CDP protocol by default.

Depends on D212908

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9df24a4001c
[remote] Update tests for explictly enabling the CDP protocol if needed. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/ee9ceda9dc3d
[remote] Do not enable CDP protocol by default. r=webdriver-reviewers,jdescottes

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46686 for changes under testing/web-platform/tests

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Attachment: Bug 1882089 - [wdspec] Remove accidentally landed test webdriver/tests/interop/beforeunload_prompt.py.

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0616057daa83
[wdspec] Remove accidentally landed test webdriver/tests/interop/beforeunload_prompt.py. r=webdriver-reviewers,jgraham DONTBUILD

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/c094d1257716
[remote] Update tests for explictly enabling the CDP protocol if needed. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/mozilla-central/rev/ccad12fea112
[remote] Do not enable CDP protocol by default. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/mozilla-central/rev/1f6dc95932ad
[wdspec] Remove accidentally landed test webdriver/tests/interop/beforeunload_prompt.py. r=webdriver-reviewers,jgraham a=graft

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c094d1257716
https://hg.mozilla.org/mozilla-central/rev/ccad12fea112
https://hg.mozilla.org/mozilla-central/rev/1f6dc95932ad

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 13

[Iulian Moraru]

Backed out for causing wd assertion failures.

• Push with failures

• Failure log

• Backout link

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

This can actually be reproduced when running the following mach command:

mach wpt --webdriver-binary=target/debug/geckodriver testing/web-platform/mozilla/tests/webdriver/cdp testing/web-platform/mozilla/tests/webdriver/classic/protocol/

The problematic tests that cause this failure are actually in testing/web-platform/mozilla/tests/webdriver/cdp/debugger_address.py. Note that we explicitly set the remote.active-protocols preference to 2 which means CDP-only enabled. Because the preference is not cleared the classic tests, which follow right after that, where we need WebDriver BiDi enabled start failing because the preference hasn't been reset.

What's interesting is that the Wd3 jobs of the try build that I pushed with the latest fixes did not fail:
https://treeherder.mozilla.org/jobs?repo=try&revision=1b7218c48311684023b81fb8364f3be9f64824a3

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bdd1a3d3ce6
[remote] Update tests for explictly enabling the CDP protocol if needed. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/c5d5af7927ef
[remote] Do not enable CDP protocol by default. r=webdriver-reviewers,jdescottes

Comment 16

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5bdd1a3d3ce6
https://hg.mozilla.org/mozilla-central/rev/c5d5af7927ef